Merge lp://qastaging/~cmiller/desktopcouch/default-context-gets-keyringclass-instance into lp://qastaging/desktopcouch
Proposed by
Chad Miller
Status: | Merged |
---|---|
Approved by: | dobey |
Approved revision: | 203 |
Merged at revision: | 201 |
Proposed branch: | lp://qastaging/~cmiller/desktopcouch/default-context-gets-keyringclass-instance |
Merge into: | lp://qastaging/desktopcouch |
Diff against target: |
44 lines (+7/-2) 2 files modified
desktopcouch/local_files.py (+1/-1) desktopcouch/platform/linux/keyring.py (+6/-1) |
To merge this branch: | bzr merge lp://qastaging/~cmiller/desktopcouch/default-context-gets-keyringclass-instance |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
dobey (community) | Approve | ||
Eric Casteleijn (community) | Approve | ||
Review via email:
|
Commit message
Get an instance of the Keyring object to pass around in the Context, not the class Keyring.
Additionally, catch and discard the kind of exception that signals that the keyring is not available, and make it return the default value.
To post a comment you must log in.
I doubt it's due to this change, but I get this test-failure:
======= ======= ======= ======= ======= ======= ======= ======= ======= ======= ======= == pair.tests. test_couchdb_ io.TestCouchdbI o.test_ get_my_ host_unique_ id
[FAIL]: desktopcouch.
Traceback (most recent call last): eric/canonical/ desktopcouch/ default- context- gets-keyringcla ss-instance/ desktopcouch/ pair/tests/ test_couchdb_ io.py", line 148, in test_get_ my_host_ unique_ id assertEquals( got, again) trial.unittest. FailTest: not equal: 464e-4188- 97aa-65fe117104 12'] 18a7-4fd7- bd5f-6fc918c5d3 ac']
File "/home/
self.
twisted.
a = ['aa6717f4-
b = ['eb094a86-
------- ------- ------- ------- ------- ------- ------- ------- ------- ------- ------- --