Merge lp://qastaging/~cmiller/desktopcouch/log-no-secrets-bug460974 into lp://qastaging/desktopcouch
Proposed by
Chad Miller
Status: | Merged |
---|---|
Approved by: | Elliot Murphy |
Approved revision: | 98 |
Merged at revision: | not available |
Proposed branch: | lp://qastaging/~cmiller/desktopcouch/log-no-secrets-bug460974 |
Merge into: | lp://qastaging/desktopcouch |
Diff against target: |
125 lines 3 files modified
desktopcouch/pair/couchdb_pairing/couchdb_io.py (+19/-9) desktopcouch/pair/tests/test_couchdb_io.py (+12/-0) desktopcouch/replication.py (+1/-1) |
To merge this branch: | bzr merge lp://qastaging/~cmiller/desktopcouch/log-no-secrets-bug460974 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Elliot Murphy (community) | Approve | ||
Eric Casteleijn (community) | Approve | ||
Review via email:
|
Commit message
When logging replication events, replace all oauth secrets with a string of the same length. (LP: #460974)
Don't complain about non-error when looking for service replicator items.
Use the logging object instead of general logging module, in one place.
To post a comment you must log in.
Looks great! tests pass