Merge lp://qastaging/~cmiller/desktopcouch/no-returns-in-finally into lp://qastaging/desktopcouch
Proposed by
Chad Miller
| Status: | Merged |
|---|---|
| Approved by: | John O'Brien |
| Approved revision: | 278 |
| Merged at revision: | 278 |
| Proposed branch: | lp://qastaging/~cmiller/desktopcouch/no-returns-in-finally |
| Merge into: | lp://qastaging/desktopcouch |
| Diff against target: |
8 lines (+0/-1) 1 file modified
desktopcouch/application/service.py (+0/-1) |
| To merge this branch: | bzr merge lp://qastaging/~cmiller/desktopcouch/no-returns-in-finally |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Eric Casteleijn (community) | Approve | ||
| John O'Brien (community) | Approve | ||
| dobey (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Fix one path of a service, where an exception should be received by the calling function (main, except for tests), and since we return out of the finally-block, there's no exception to send. This would make tests very hard to debug when there was a failure.
To post a comment you must log in.
Revision history for this message
| dobey (dobey) | # |
review:
Approve
Revision history for this message
| Eric Casteleijn (thisfred) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Easy