desktopcouch

Merge lp://qastaging/~cmiller/desktopcouch/pairing-murders-ini-passwords into lp://qastaging/desktopcouch

  1. pairing-murders-ini-passwords
  2. Merge into trunk
Proposed by Chad Miller
Status: Merged
Approved by: Chad Miller
Approved revision: 74
Merged at revision: not available
Proposed branch: lp://qastaging/~cmiller/desktopcouch/pairing-murders-ini-passwords
Merge into: lp://qastaging/desktopcouch
Diff against target: 12 lines
1 file modified
desktopcouch/local_files.py (+2/-0)
To merge this branch: bzr merge lp://qastaging/~cmiller/desktopcouch/pairing-murders-ini-passwords
Reviewer Review Type Date Requested Status
Nicola Larosa (community) Approve
Stuart Langridge (community) Approve
Review via email: mp+12652@code.qastaging.launchpad.net

Commit message

Do not let Python's ConfigParser transform options into lowercase, as
couchdb options are case-sensitive.

To post a comment you must log in.
Revision history for this message
Stuart Langridge (sil) wrote :

Good catch!

review: Approve
Revision history for this message
Nicola Larosa (teknico) wrote :

Makes sense, been doing this sometimes too.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'desktopcouch/local_files.py'
2--- desktopcouch/local_files.py 2009-09-18 19:22:41 +0000
3+++ desktopcouch/local_files.py 2009-09-30 11:45:21 +0000
4@@ -136,6 +136,8 @@
5
6 def set_bind_address(address, config_file_name=FILE_INI):
7 c = configparser.SafeConfigParser()
8+ # monkeypatch ConfigParser to stop it lower-casing option names
9+ c.optionxform = lambda s: s
10 c.read(config_file_name)
11 if not c.has_section("httpd"):
12 c.add_section("httpd")

Subscribers

People subscribed via source and target branches