Merge lp://qastaging/~cmiller/desktopcouch/preconditionfailed-lp707321 into lp://qastaging/desktopcouch
Proposed by
Chad Miller
| Status: | Merged |
|---|---|
| Approved by: | Chad Miller |
| Approved revision: | 269 |
| Merged at revision: | 268 |
| Proposed branch: | lp://qastaging/~cmiller/desktopcouch/preconditionfailed-lp707321 |
| Merge into: | lp://qastaging/desktopcouch |
| Diff against target: |
170 lines (+104/-15) 2 files modified
desktopcouch/records/database.py (+14/-10) desktopcouch/records/tests/test_mocked_server.py (+90/-5) |
| To merge this branch: | bzr merge lp://qastaging/~cmiller/desktopcouch/preconditionfailed-lp707321 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Roberto Alsina (community) | Approve | ||
| Eric Casteleijn (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Change creation of the Database object to EAFP. LBYL is impossible with HTTP and no locking. If create-flag is set, then go do it and swallow an exception about it already existing. (LP: #707321)
In addition, simplify that code so it makes fewer round-trips to the server.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Looks good, let's land it and run it past one of the bug reporters to see if it fixes it for them.