desktopcouch

Merge lp://qastaging/~cmiller/desktopcouch/record-ids-smaller into lp://qastaging/desktopcouch

  1. record-ids-smaller
  2. Merge into trunk
Proposed by Chad Miller
Status: Merged
Approved by: Eric Casteleijn
Approved revision: 186
Merged at revision: 212
Proposed branch: lp://qastaging/~cmiller/desktopcouch/record-ids-smaller
Merge into: lp://qastaging/desktopcouch
Diff against target: 91 lines (+35/-18)
1 file modified
desktopcouch/records/server_base.py (+35/-18)
To merge this branch: bzr merge lp://qastaging/~cmiller/desktopcouch/record-ids-smaller
Reviewer Review Type Date Requested Status
Chad Miller (community) Approve
Eric Casteleijn (community) Approve
Vincenzo Di Somma (community) Approve
Review via email: mp+39695@code.qastaging.launchpad.net

Commit message

Use compact string representations of UUID integers for record IDs. (LP: #530911)

To post a comment you must log in.
Revision history for this message
Vincenzo Di Somma (vds) wrote :

Thanks.

review: Approve
Revision history for this message
Eric Casteleijn (thisfred) wrote :

Looks good. Why did you make the docstring not be doctestable anymore though?

review: Approve
Revision history for this message
John Lenton (chipaca) wrote :

May I suggest using the divmod() builtin to avoid doing the modulo arithmetic twice?

lp://qastaging/~cmiller/desktopcouch/record-ids-smaller updated
186. By Chad Miller

Use divmod() builtin for single arithmetic op, at cost of new references.

Revision history for this message
Chad Miller (cmiller) wrote :

Thanks, Chipaca. I forgot about that builtin.

Eric, the docstring wasn't a test before. Making it so might be hard, considering the mainloop involvement.

Revision history for this message
Eric Casteleijn (thisfred) wrote :

Right, so let's not do that. I'd still like a syntax that didn't look like it was almost a doctest, but it's not important. Approving.

Revision history for this message
Chad Miller (cmiller) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches