Merge lp://qastaging/~cmiller/desktopcouch/retry-on-couchdb-death-bug530541 into lp://qastaging/desktopcouch

Proposed by Chad Miller
Status: Merged
Approved by: Eric Casteleijn
Approved revision: 149
Merged at revision: not available
Proposed branch: lp://qastaging/~cmiller/desktopcouch/retry-on-couchdb-death-bug530541
Merge into: lp://qastaging/desktopcouch
Diff against target: 26 lines (+15/-1)
1 file modified
desktopcouch/start_local_couchdb.py (+15/-1)
To merge this branch: bzr merge lp://qastaging/~cmiller/desktopcouch/retry-on-couchdb-death-bug530541
Reviewer Review Type Date Requested Status
Eric Casteleijn (community) Approve
Tim Cole (community) Approve
Review via email: mp+23280@code.qastaging.launchpad.net

Commit message

Add a retry loop around the code that tries to get the PID and use the PID to find the port of desktopcouch. It will retry nine more times now, sleeping one second between each attempt.

To post a comment you must log in.
Revision history for this message
Tim Cole (tcole) :
review: Approve
Revision history for this message
Eric Casteleijn (thisfred) wrote :

The code, it looks good.
The tests, they pass.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches