Merge lp://qastaging/~cmiller/desktopcouch/sso-app-fixes into lp://qastaging/desktopcouch

Proposed by Chad Miller
Status: Merged
Approved by: Vincenzo Di Somma
Approved revision: 174
Merged at revision: 174
Proposed branch: lp://qastaging/~cmiller/desktopcouch/sso-app-fixes
Merge into: lp://qastaging/desktopcouch
Diff against target: 73 lines (+30/-12)
2 files modified
desktopcouch/start_local_couchdb.py (+10/-11)
desktopcouch/tests/test_start_local_couchdb.py (+20/-1)
To merge this branch: bzr merge lp://qastaging/~cmiller/desktopcouch/sso-app-fixes
Reviewer Review Type Date Requested Status
Vincenzo Di Somma (community) Approve
Manuel de la Peña (community) Approve
Review via email: mp+35841@code.qastaging.launchpad.net

Commit message

Fix one typo in an exception name, move default value settings higher to make exec paths irrelevant to their existence, and restructure code to make it testable and tested (LP: #641381)

To post a comment you must log in.
Revision history for this message
Manuel de la Peña (mandel) wrote :

superb!

review: Approve
Revision history for this message
Vincenzo Di Somma (vds) wrote :

Great! Thanks for fixing it so quickly! :)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches