Merge lp://qastaging/~coalwater/lernid/fix-812427 into lp://qastaging/lernid
Proposed by
Mohammad AbuShady
| Status: | Merged |
|---|---|
| Approved by: | John S. Gruber |
| Approved revision: | 228 |
| Merged at revision: | 229 |
| Proposed branch: | lp://qastaging/~coalwater/lernid/fix-812427 |
| Merge into: | lp://qastaging/lernid |
| Diff against target: |
13 lines (+2/-1) 1 file modified
lernid/widgets/Schedule.py (+2/-1) |
| To merge this branch: | bzr merge lp://qastaging/~coalwater/lernid/fix-812427 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| John S. Gruber | Approve | ||
|
Review via email:
|
|||
Description of the change
Ok so I've tested it and it's working but i noticed one small thing, when i changed my nick from 'coalwater' to 'CoAlWaTeR', the following messages didn't realize my nick was changed, it still wrote the old 'coalwater' and bolded my text as an instructor, after i tried a /cycle, the new nick started to appear, i don't know if we should be handle this or not, since it's a really rare case.
Other than that i think my branch is ready to be tested
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Excellent. If I understand your comment I don't think the behaviour you describe is at all related to your patch--it's simply how lernid works. Lernid get's the user's nickname once and then cache's it for performance reasons.
Your patch works for me and I intent to apply it for the next release, if possible.
Thank you.