Merge ~codersquid/hwcert-tools:sfhistory into hwcert-tools:master

Proposed by Sheila Miguez
Status: Merged
Approved by: Paul Larson
Approved revision: c2c43a332fcb8326313fab7a4e1934a875bdd7ad
Merged at revision: c2c43a332fcb8326313fab7a4e1934a875bdd7ad
Proposed branch: ~codersquid/hwcert-tools:sfhistory
Merge into: hwcert-tools:master
Diff against target: 1187 lines (+1133/-0)
9 files modified
.gitignore (+17/-0)
inventory_history/README.rst (+61/-0)
inventory_history/c.conf-dist (+11/-0)
inventory_history/inventory_history/__init__.py (+17/-0)
inventory_history/inventory_history/hardware_inventory_job.py (+528/-0)
inventory_history/requirements.txt (+5/-0)
inventory_history/salesforceimporter.py (+115/-0)
inventory_history/tests/__init__.py (+17/-0)
inventory_history/tests/test_inventory_history.py (+362/-0)
Reviewer Review Type Date Requested Status
Paul Larson Approve
Review via email: mp+269270@code.qastaging.launchpad.net

Description of the change

The Certification app (C3) recently started tracking inventory so that operations will be able to move away from using Salesforce for tracking inventory. These scripts allow one to import historical inventory values to C3. This adds a new command called `salesforceimporter.py` which runs a HardwareInventoryJob against Salesforce and C3 environments.

To post a comment you must log in.
Revision history for this message
Paul Larson (pwlars) wrote :

Mostly minor comments that I'll leave to your discretion, but one typo in "failefast" that you should probably fix.

review: Needs Fixing
Revision history for this message
Paul Larson (pwlars) wrote :

+1

review: Approve
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

I will try to merge this branch. I will keep you posted

Revision history for this message
Zygmunt Krynicki (zyga) wrote :

The branch has been merged as requested. Thank you for your contribution

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches