Compiz Configuration Library - Python Bindings

Merge lp://qastaging/~compiz-team/compiz-compizconfig-python/compiz-compizconfig-python.fix_874799 into lp://qastaging/compiz-compizconfig-python

  1. compiz-compizconfig-python.fix_874799
  2. Merge into 0.9.5
Proposed by Sam Spilsbury
Status: Merged
Approved by: Tim Penhey
Approved revision: 174
Merged at revision: 168
Proposed branch: lp://qastaging/~compiz-team/compiz-compizconfig-python/compiz-compizconfig-python.fix_874799
Merge into: lp://qastaging/compiz-compizconfig-python
Diff against target: 226 lines (+130/-4)
9 files modified
CMakeLists.txt (+13/-0)
setup.py (+26/-2)
src/compizconfig.pyx (+4/-2)
tests/__init__.py (+11/-0)
tests/compiz_config_test.py (+11/-0)
tests/test_backend.py (+15/-0)
tests/test_plugin.py (+17/-0)
tests/test_profile.py (+12/-0)
tests/test_setting.py (+21/-0)
To merge this branch: bzr merge lp://qastaging/~compiz-team/compiz-compizconfig-python/compiz-compizconfig-python.fix_874799
Reviewer Review Type Date Requested Status
Tim Penhey (community) Approve
Review via email: mp+79454@code.qastaging.launchpad.net

Description of the change

Bug 874799

To post a comment you must log in.
lp://qastaging/~compiz-team/compiz-compizconfig-python/compiz-compizconfig-python.fix_874799 updated
167. By Sam Spilsbury

Fix conflicts

Revision history for this message
Tim Penhey (thumper) wrote :

Are there any tests for this project at all?

Revision history for this message
Sam Spilsbury (smspillaz) wrote :

CCSM is a testcase ;-)

I think it might be useful to have a simple python script that excersizes all the bindings.

Revision history for this message
Sam Spilsbury (smspillaz) wrote :

(manual testcase: open ccsm and go to the profiles section and there will be no "garbage" profiles there.

Revision history for this message
Tim Penhey (thumper) :
review: Approve
lp://qastaging/~compiz-team/compiz-compizconfig-python/compiz-compizconfig-python.fix_874799 updated
168. By Sam Spilsbury

Added some tests

169. By Sam Spilsbury

Added a test target to distutils setup.py

170. By Sam Spilsbury

Added some CTest wrapper around the distutils testing stuff

171. By Sam Spilsbury

Added a simple test for CCSPlugin

172. By Sam Spilsbury

Added Backend test

173. By Sam Spilsbury

Remove useless line from setup.py

174. By Sam Spilsbury

Added test for Setting

Revision history for this message
Tim Penhey (thumper) wrote :

Thanks Sam. The world will thank you :-)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: