Merge lp://qastaging/~compiz-team/compiz-core/compiz-core.fix_853734 into lp://qastaging/~compiz-team/compiz-core/compiz-core.stack_sync_fix

Proposed by Sam Spilsbury
Status: Superseded
Proposed branch: lp://qastaging/~compiz-team/compiz-core/compiz-core.fix_853734
Merge into: lp://qastaging/~compiz-team/compiz-core/compiz-core.stack_sync_fix
Diff against target: 483 lines (+162/-72)
3 files modified
src/privatewindow.h (+1/-0)
src/window.cpp (+153/-64)
src/windowgeometry.cpp (+8/-8)
To merge this branch: bzr merge lp://qastaging/~compiz-team/compiz-core/compiz-core.fix_853734
Reviewer Review Type Date Requested Status
Compiz Maintainers Pending
Review via email: mp+75992@code.qastaging.launchpad.net

This proposal has been superseded by a proposal from 2011-09-19.

Commit message

Ensure that we update frame regions correctly by doing the following:
 * Only update frame regions when we get an event that something changed
   server side (eg don't immediately update the region once we issue
   a ConfigureWindow request)
 * Keep track of the changes in the input extents
 * Ensure that a synthetic ConfigureNotify is sent in cases where the resized
   frame window will exactly match its last size such that the client is
   positioned correctly inside the frame

Description of the change

  Ensure that we update frame regions correctly by doing the following:
   * Only update frame regions when we get an event that something changed
     server side (eg don't immediately update the region once we issue
     a ConfigureWindow request)
   * Keep track of the changes in the input extents
   * Ensure that a synthetic ConfigureNotify is sent in cases where the resized
     frame window will exactly match its last size such that the client is
     positioned correctly inside the frame

To post a comment you must log in.
Revision history for this message
Mirco Müller (macslow) wrote :

I'm not able to compile compiz here atm. But what I suggest is to initialize all declared variables.

Revision history for this message
Mikkel Kamstrup Erlandsen (kamstrup) wrote :

I can confirm that maximize->minimize works fine here. And generally everything seems to work fine. Haven't had time to do code review.

2818. By Sam Spilsbury

Merge lp:~compiz-team/compiz-core/compiz-core.fix_853734

Unmerged revisions

2818. By Sam Spilsbury

Merge lp:~compiz-team/compiz-core/compiz-core.fix_853734

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: