Merge lp://qastaging/~compiz-team/compiz-core/compiz-core.notify_occlusion_detection into lp://qastaging/compiz-core/0.9.5
Proposed by
Sam Spilsbury
Status: | Rejected |
---|---|
Rejected by: | Sam Spilsbury |
Proposed branch: | lp://qastaging/~compiz-team/compiz-core/compiz-core.notify_occlusion_detection |
Merge into: | lp://qastaging/compiz-core/0.9.5 |
Diff against target: |
93 lines (+44/-2) 1 file modified
plugins/decor/src/decor.cpp (+44/-2) |
To merge this branch: | bzr merge lp://qastaging/~compiz-team/compiz-core/compiz-core.notify_occlusion_detection |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Tim Penhey (community) | Needs Fixing | ||
Review via email:
|
To post a comment you must log in.
Unmerged revisions
- 2798. By Sam Spilsbury
-
Notify that we're doing occlusion detection
- 2797. By Sam Spilsbury
Hi Sam,
This screams for a private function. If that isn't possible for ABI break
reasons, please add a note to refactor ASAP.
"o" is a terrible name for a variable. Also, using the correct constructor
for the vector means avoiding a call to resize.
void WHATEVER: :ComputeShadows ForScreen( Screen* screen) :Vector options(1); :TypeBool) ;
{
CompOption:
CompOption& option = options.back ();
option = CompOption ("active", CompOption:
option.value ().set (true);
screen- >handleCompizEv ent ("decor", "occlusion_ detection" , options);
DecorScreen ::get (screen) ->cScreen- >getWindowPaint List ()) ::get (cw)->computeSh adowRegion (); >handleCompizEv ent ("decor", "occlusion_ detection" , options);
foreach (CompWindow *cw,
{
DecorWindow
}
option.value ().set (false);
screen-
}