lp://qastaging/~compiz-team/compiz/compiz.fix_1037142

Branch merges

Propose for merging

No branches dependent on this one.

Superseded for merging into lp://qastaging/compiz/0.9.8

Daniel van Vugt: Needs Resubmitting on 2012-09-24

jenkins (community): Needs Fixing (continuous-integration) on 2012-09-22

Diff: 317 lines (+111/-39)

6 files modified

plugins/expo/src/expo.cpp (+0/-26)
plugins/grid/src/grabhandler/include/grabhandler.h (+38/-2)
plugins/grid/src/grabhandler/src/grabhandler.cpp (+7/-2)
plugins/grid/src/grabhandler/tests/test-grid-grab-handler.cpp (+58/-5)
plugins/grid/src/grid.cpp (+5/-1)
src/event.cpp (+3/-3)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1037142: Week33 - Grid highlight window appears while switching between workspaces

Medium

Fix Released

Link a bug report

Related blueprints

3391. By Sam Spilsbury on 2012-09-22

Don't trigger the grid grab handler when expo is active, don't trigger
inactive actions and remove redundant checks for the root window match
because we don't support the multi-screen case and haven't since
0.9.0

3390. By Sam Spilsbury on 2012-09-21

Don't trigger actions unless they're actually added

3389. By Sam Spilsbury on 2012-09-21

Restrict access of private data in CompAction to a separate nonmember
function, add a test for its usage

3388. By Sam Spilsbury on 2012-09-21

Refactored out the rest of that function and tested it

3387. By Sam Spilsbury on 2012-09-21

Reworked the way actions are set up to be more in line with how
compiz expects it. Now the tests pass

3386. By Sam Spilsbury on 2012-09-21

Split out some of triggerButtonPressBindings and get it under test, currently
some tests fail due to incorrect behaviour in CompOption::set, a failing
test added to show this

3385. By Sam Spilsbury on 2012-09-21

Use boost::bind

3384. By Sam Spilsbury on 2012-09-21

Move the check for the button action modifiers & event state to a separate
function

3383. By Sam Spilsbury on 2012-09-21

Refactored out the edge detection code from triggerButtonPressBindings
into a separate util function under test

3382. By Sam Spilsbury on 2012-09-20

This adds a system testing framework based on Xorg-GTest (launchpad.net/xorg-gtest). It will find an existing installation of xorg-gtest and compile it locally (similar to Google Test) and provides a class XorgSystemTest in the namespace compiz::testing, which will spawn compiz inside of a dummy X Sever. You can then test by interacting with the server and querying its state.

XEventMatcher is a very basic concept for matching X events as they come in. Right now, the events have to be matched in order, but its feasible that in future we could have out of order matching like we do in Google Mock. Some utility functions added on top of xorg-gtest were WaitForEventOfTypeOnWindow, which works just like the former function by checks if it matches a window or satisfies some arbitrary criteria in the case of WaitForEventOfTypeOnWindowMatching.. Fixes: . Approved by Daniel van Vugt, jenkins.