Merge lp://qastaging/~compiz-team/compiz/compiz.fix_1050610 into lp://qastaging/compiz/0.9.8
| Status: | Merged |
|---|---|
| Approved by: | Daniel van Vugt |
| Approved revision: | 3396 |
| Merged at revision: | 3398 |
| Proposed branch: | lp://qastaging/~compiz-team/compiz/compiz.fix_1050610 |
| Merge into: | lp://qastaging/compiz/0.9.8 |
| Diff against target: |
49 lines (+34/-0) 2 files modified
gtk/window-decorator/wnck.c (+22/-0) tests/manual/GTKWindowDecoratorResourceUsage.txt (+12/-0) |
| To merge this branch: | bzr merge lp://qastaging/~compiz-team/compiz/compiz.fix_1050610 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Daniel van Vugt | Approve | ||
| jenkins (community) | continuous-integration | Needs Fixing | |
|
Review via email:
|
|||
Commit message
Fix window handle leak causing gradual degradation in desktop performance.
(LP: #1050610)
Description of the change
Destroy input windows once we're done with them (Fixes bug 1050610).
At the moment there are no tests for this code. I had a look at what it would take to get this code under test (properly, eg, "That destroying the decoration results in destroying the input windows") and it would be a substantial amount, eg
1. Abstracting decor_t - event_windows
2. Abstracting making decor_t individually instantiable and injecting Gtk+ / GDK dependent stuff into it etc
This involves a lot of work and quite a lot of change. I think its definitely worthwhile to focus on this immediately for 0.9.9, but time constraints and the quality tradeoff here make it not worth it for 0.9.8
| jenkins (martin-mrazik+qa) wrote | # |
FAILED: Continuous integration, rev:3396
http://
Executed test runs:
FAILURE: http://