lp://qastaging/~compiz-team/compiz/compiz.fix_1101026

Created by Sam Spilsbury and last modified
Get this branch:
bzr branch lp://qastaging/~compiz-team/compiz/compiz.fix_1101026
Members of Compiz Maintainers can upload to this branch. Log in for directions.

Branch merges

Related bugs

Related blueprints

Branch information

Owner:
Compiz Maintainers
Project:
Compiz
Status:
Merged

Recent revisions

3659. By Sam Spilsbury

Add whitespace where it makes sense, remove double whitespace

3658. By Sam Spilsbury

Added some new hooks to PluginClassHandler to allow a VTable to specify if loaded.

PluginClassHandler::get () was designed to simply instantiate an instance of that
class for the core structure, but it did this without checking if the plugin was
loaded.

Added some new methods to PluginClassHandler exposed by LoadedPluginClassBridge
and only accessible by those who implement PluginKey to specify globally
whether or not a plugin is actually loaded, so that PluginClassHandler can
return accordingly.

Integration and unit tests added as appropriate

(LP: #1169620)
(LP: #1101026)

3657. By Sam Spilsbury

Install compizconfig backends to the correct libdir

(LP: #1163611). Fixes: https://bugs.launchpad.net/bugs/1163611.

Approved by PS Jenkins bot, MC Return.

3656. By MC Return

Screenshot code cleanup:

Used standard bool for mGrab.
Merged a few if condition checks.
Declaration and assignment of local variables in one line.
Removed redundant brackets.
Added and removed newlines to improve readability.
Added a missing break (just a style issue).
Fixed indentation.
C++ style for comments.

Approved by PS Jenkins bot, Sam Spilsbury.

3655. By MC Return

Freewins xml:
Fixed False->false and True->true typos.

Credits and thanks for finding cause and fix go to raveit65 !

(LP: #1163606). Fixes: https://bugs.launchpad.net/bugs/1163606.

Approved by PS Jenkins bot, Sam Spilsbury.

3654. By MC Return

*Move xml:

Implemented options to configure:

"Snapoff Distance"
"Snapback Semimaximized Windows" and
"Snapback Distance"

Improved a few tooltips.

*Move code:

Replaced SNAP_BACK and SNAP_OFF hardcoded constants and made those
configurable.

Implemented a strategy to snap off horizontally maximized windows by
dragging them along the x axis.

Implemented snapping back of horizontally maximized windows and fixed
the snapping for vertically maximized windows (wrong cursor calculation).

Fixed a few wrong calculations in the if condition checks responsible
for snapping off and back.

Merged if condition checks.

Just compute various local variables if we do not return false.

Removed redundant brackets, fixed indentation and improved readability.

(LP: #1165198, LP: #1167933). Fixes: https://bugs.launchpad.net/bugs/1165198, https://bugs.launchpad.net/bugs/1167208, https://bugs.launchpad.net/bugs/1167933.

Approved by PS Jenkins bot, Sam Spilsbury.

3653. By Hu Kang <email address hidden>

workarounds.cpp: Fix typo in call to XShapeSelectInput.

(LP: #1167284). Fixes: https://bugs.launchpad.net/bugs/1167284.

Approved by PS Jenkins bot, Sam Spilsbury.

3652. By Sam Spilsbury

Also take into account the gravity requirements when validating reposition
requests. Get most of that code under test too.

(LP: #1159324). Fixes: https://bugs.launchpad.net/bugs/1159324.

Approved by PS Jenkins bot, Sam Spilsbury.

3651. By MC Return

*Resizeinfo, xml changes:

Added option for bold/normal font, default is still bold.

Added option to change the font size (10-14), default is still 12
pixel.

Enhanced and corrected a few tooltips.

*Resizeinfo, code changes:

Choose between PANGO_WEIGHT_BOLD and PANGO_WEIGHT_NORMAL.

Use individual font size specified by the user in CCSM.

Fixed computation of wrong damageRegion, it was additionally adding
the window size, making it way too large.

Removed useless declaration of int width and height.

Declaration and assignment of local variables in one line, if possible.

Minor indentation fixes.

(LP: #1166195, LP: #1166196 and LP: #1166245). Fixes: https://bugs.launchpad.net/bugs/1166195, https://bugs.launchpad.net/bugs/1166196, https://bugs.launchpad.net/bugs/1166245.

Approved by PS Jenkins bot, Sam Spilsbury.

3650. By Sami Jaktholm

*Grid code:

Prevent center and corner gridded windows from jumping viewports.
(Thanks and credits for this go to Sami Jaktholm)

Prevent top and bottom gridded windows from jumping viewports by
making those semi-maximize horizontally.

As those are actually semi-maximized horizontally, we will treat
them as such and let core handle the restoring, just like we
already do for vertically semi-maximized grid windows (left/right).

Now "Strg+Super+Down" will restore top and bottom gridded windows
correctly as well.

Also multiple gridding to top, bottom, left or right will not
overwrite the stored original size anymore.

Restore windows also when workspace switcher (expo) is active.
(Thanks and credits for this go to Sami Jaktholm)

Allow cycling for all gridded windows if explicitly specified by the
user in CCSM.

Forbid cycling through different sizes for corner and center-gridded
windows also per default, now fully fixing bug #878820 and following
the design specification by Ayatana Design there, making behaviour
consistent.

Introduced 3 new bools:
horzMaximizedGridPosition,
vertMaximizedGridPosition,
anyMaximizedGridPosition

Used these bools inside the if condition checks.
Simplified complicated if condition by removing redundant additional
size check.

Cleanup all around.

*Grid xml:

Added cycle_sizes bool option, which allows the user to choose the
prefered behaviour (fixed versus flexible sizes on multiple presses
on the same grid keyboard shortcut).
Default of this option is off, cycling disabled as specified by design.

Added punctuation where missing and removed it where usually is none.
Fixed typos, improved description and titles.

*Expo code:
Tell grid when viewport change is in progress.
(Thanks and credits for this go to Sami Jaktholm)

(fixes: LP: #878820, LP: #879218, LP: #882754 and LP: #1082001,
 partially fixes: #1116538, #1164332). Fixes: https://bugs.launchpad.net/bugs/878820, https://bugs.launchpad.net/bugs/879218, https://bugs.launchpad.net/bugs/882754, https://bugs.launchpad.net/bugs/1082001, https://bugs.launchpad.net/bugs/1116538, https://bugs.launchpad.net/bugs/1164332.

Approved by PS Jenkins bot, Sami Jaktholm, Sam Spilsbury.

Branch metadata

Branch format:
Branch format 7
Repository format:
Bazaar repository format 2a (needs bzr 1.16 or later)
Stacked on:
lp://qastaging/compiz/0.9.10
This branch contains Public information 
Everyone can see this information.