Compiz

Merge lp://qastaging/~compiz-team/compiz/compiz.fix_1124313 into lp://qastaging/compiz/0.9.9

  1. compiz.fix_1124313
  2. Merge into 0.9.9
Proposed by Sam Spilsbury
Status: Merged
Approved by: Łukasz Zemczak
Approved revision: 3607
Merged at revision: 3608
Proposed branch: lp://qastaging/~compiz-team/compiz/compiz.fix_1124313
Merge into: lp://qastaging/compiz/0.9.9
Diff against target: 12 lines (+0/-2)
1 file modified
CMakeLists.txt (+0/-2)
To merge this branch: bzr merge lp://qastaging/~compiz-team/compiz/compiz.fix_1124313
Reviewer Review Type Date Requested Status
Łukasz Zemczak Approve
PS Jenkins bot (community) continuous-integration Approve
Andrea Azzarone Pending
Review via email: mp+148433@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2013-02-13.

Commit message

We don't need CMAKE_THREADS_LIB

(LP: #1124133)

Description of the change

We don't need CMAKE_THREADS_LIB

(LP: #1124133)

To post a comment you must log in.
Revision history for this message
Andrea Azzarone (azzar1) : Posted in a previous version of this proposal
review: Approve
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Posted in a previous version of this proposal

Yep, looking good, waiting for CI. But now it's +1.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:3607
http://jenkins.qa.ubuntu.com/job/compiz-ci/31/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/compiz-clang-ci/./build=pbuilder,distribution=raring,flavor=amd64/69/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/compiz-gles-ci/./build=pbuilder,distribution=raring,flavor=amd64/68/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/compiz-pbuilder/./build=pbuilder,distribution=raring,flavor=amd64/420/console

Click here to trigger a rebuild:
http://jenkins.qa.ubuntu.com/job/compiz-ci/31//rebuild/?

review: Needs Fixing (continuous-integration)
Revision history for this message
Sam Spilsbury (smspillaz) wrote : Posted in a previous version of this proposal

Okay, the clang-job is stuffed because the compiler crashes on compiling google-test :( . I've asked mmrazik to disable google

Revision history for this message
Sam Spilsbury (smspillaz) wrote : Posted in a previous version of this proposal

*google-test compilation. Yikes, dunno what the world would be like if we disabled "google"

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:3607
http://jenkins.qa.ubuntu.com/job/compiz-ci/38/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/compiz-clang-ci/./build=pbuilder,distribution=raring,flavor=amd64/76/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/compiz-gles-ci/./build=pbuilder,distribution=raring,flavor=amd64/75/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/compiz-pbuilder/./build=pbuilder,distribution=raring,flavor=amd64/427/console

Click here to trigger a rebuild:
http://jenkins.qa.ubuntu.com/job/compiz-ci/38//rebuild/?

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:3607
http://jenkins.qa.ubuntu.com/job/compiz-ci/39/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/compiz-gles-ci/./build=pbuilder,distribution=raring,flavor=amd64/76/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/compiz-pbuilder/./build=pbuilder,distribution=raring,flavor=amd64/428/console

Click here to trigger a rebuild:
http://jenkins.qa.ubuntu.com/job/compiz-ci/39//rebuild/?

review: Approve (continuous-integration)
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

+1 again

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches