Compiz

Merge lp://qastaging/~compiz-team/compiz/compiz.fix_1138517 into lp://qastaging/compiz/0.9.9

  1. compiz.fix_1138517
  2. Merge into 0.9.9
Proposed by Sam Spilsbury
Status: Merged
Approved by: Timo Jyrinki
Approved revision: 3632
Merged at revision: 3633
Proposed branch: lp://qastaging/~compiz-team/compiz/compiz.fix_1138517
Merge into: lp://qastaging/compiz/0.9.9
Diff against target: 393 lines (+219/-44)
4 files modified
plugins/decor/src/decor.cpp (+30/-21)
src/privatewindow.h (+2/-2)
src/window.cpp (+27/-10)
tests/system/xorg-gtest/tests/compiz_xorg_gtest_configure_window.cpp (+160/-11)
To merge this branch: bzr merge lp://qastaging/~compiz-team/compiz/compiz.fix_1138517
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Timo Jyrinki Approve
MC Return Pending
Review via email: mp+152623@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2013-03-06.

Commit message

Don't set lastFrameExtents unless the window geometry actually changed - as
that variable only exists to track changes in the actual geometry of
the window and not the apparant frame extents.

Added tests to verify that behaviour.

(LP: #1138517)

Description of the change

Don't set lastFrameExtents unless the window geometry actually changed - as
that variable only exists to track changes in the actual geometry of
the window and not the apparant frame extents.

Added tests to verify that behaviour.

(LP: #1138517)

To post a comment you must log in.
Revision history for this message
MC Return (mc-return) wrote : Posted in a previous version of this proposal

+1.

review: Approve
Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote : Posted in a previous version of this proposal

With this branch I couldn't resize or move Java windows (like jEdit) anymore. Reverting to the archive fixed the issue.

review: Disapprove
Revision history for this message
Sam Spilsbury (smspillaz) wrote : Posted in a previous version of this proposal

I'm sure you meant "needs fixing" not disapprove. In any case I can have
another look into it. I didn't test with jedit but java is such a bloody
disaster that I'm not even sure I care anymore.
On 11/03/2013 1:39 PM, "Timo Jyrinki" <email address hidden> wrote:

> Review: Disapprove
>
> With this branch I couldn't resize or move Java windows (like jEdit)
> anymore. Reverting to the archive fixed the issue.
> --
>
> https://code.launchpad.net/~compiz-team/compiz/compiz.fix_1138517/+merge/151941
> Your team Compiz Maintainers is subscribed to branch lp:compiz.
>

Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote : Posted in a previous version of this proposal

(or: Needs Fixing .. the problematic bzr 3616 was already reverted, but of course a proper fix could be nicer anyhow so that the 3616 could be resubmitted)

Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote : Posted in a previous version of this proposal

Sure, Needs Fixing it is.

review: Needs Fixing
Revision history for this message
Andrea Azzarone (azzar1) : Posted in a previous version of this proposal
review: Approve
Revision history for this message
Andrea Azzarone (azzar1) wrote : Posted in a previous version of this proposal

Ops wrong branch.

Revision history for this message
Andrea Azzarone (azzar1) : Posted in a previous version of this proposal
review: Abstain
Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

Tested also this branch, it worked as well now.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches