lp://qastaging/~compiz-team/compiz/compiz.fix_1184755

Branch merges

Propose for merging

No branches dependent on this one.

Superseded for merging into lp://qastaging/compiz/0.9.10

Compiz Maintainers: Pending requested 2013-04-28

Diff: 79 lines (+31/-13)

2 files modified

cmake/CompizGSettings.cmake (+10/-1)
compizconfig/ccsm/setup.py (+21/-12)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1168475: make uninstall doesn't remove all files

High

In Progress

Link a bug report

Related blueprints

3681. By Sam Spilsbury on 2013-04-28

Fix some files not installing:

 1. gsettings schemas never get added to the install_manifest list
    because we use install (CODE) so we need to add a custom
    uninstall target for those, and also need to recompile on uninstall
    too
 2. Run the gtk-update-icon-cache stage during install for ccsm and
    also add icon-theme.cache to the uninstall target

3680. By MC Return on 2013-04-28

shift.h:
Minor indentation fixes (mostly replaced tabs with spaces).

Approved by PS Jenkins bot, Sam Spilsbury.

3679. By MC Return on 2013-04-27

Refactor screenshot code to make it clearer and also to allow us to take
screenshots in glPaintOutput as opposed to paint ().

Taking screenshots in paint () was probably correct pre-GLES, but isn't
really correct now - we want to be able to read off of the currently
bound scratch framebuffer where we last painted the frame. Reading off
the frontbuffer is an imprecise operation because the contents of both
buffers are really undefined after a swap. In the case where we are
not painting to a scratch framebuffer object, we'll just end up reading
from the backbuffer anyways, which would be correct to do mid-frame.

Also added the new static const GLenums
DRAW_FRAMEBUFFER_BINDING and
READ_FRAMEBUFFER_BINDING to opengl.h.

(LP: #771875). Fixes: https://bugs.launchpad.net/bugs/771875.

Approved by PS Jenkins bot, Sam Spilsbury.

3678. By MC Return on 2013-04-27

Shift Switcher .xml cleanup:

Better description of the plugin's function.
Fixed load before "bs" plugin typo -> it is the obs plugin.
Created a "Switcher Mode" tab and moved Flip/Cover mode settings there.
Created a subgroup for mouse-specific settings.
Better tooltips with enhanced descriptions.
Improved titles.
Fixes all around (typos, etc.).

Approved by PS Jenkins bot, Sam Spilsbury.

3677. By MC Return on 2013-04-27

Cube .xml cleanup:

Better plugin description.
Uppercase titles.
Improved tooltips.

Approved by PS Jenkins bot, Sam Spilsbury.

3676. By Sam Spilsbury on 2013-04-27

Rewrite screen size change tests.

1. Rename the overly-terse variables names to variables names that have some
   significance
2. Split the giant three-test structure into multiple tests each with only one
   assert
3. Remove a lot of redundant calculation
4. Remove magic numbers peppered throughout the code. Use constants and
   express asserts as relationships between those constants.
5. Refactor some of the more common test-advancement code (such as changing
   the screen size) into the test fixture as common methods.

(LP: #1167983). Fixes: https://bugs.launchpad.net/bugs/1167983.

Approved by PS Jenkins bot, Steve Langasek.

3675. By MC Return on 2013-04-26

Workspacenames .xml cleanup:

Better description of the plugin's functionality.
Improved tooltips.

Approved by PS Jenkins bot, Sam Spilsbury.

3674. By MC Return on 2013-04-26

Grid, code cleanup:

Merged if statements.
Replaced magic number 65535.0f with const float MaxUShortFloat =
std::numeric_limits <unsigned short>::max ();.
Use prefix- instead of postfix-increment.
Removed redundant (float) casts.
Removed redundant brackets.
Added and removed newlines to improve readability.
Minor indentation fixes.

Approved by PS Jenkins bot, Sam Spilsbury.

3673. By MC Return on 2013-04-26

Animation code cleanup:

Use prefix- instead of postfix- in- and decrements.
Removed redundant brackets.
Added and removed newlines where appropriate.
Fixed indentation.

Approved by PS Jenkins bot, Sam Spilsbury.

3672. By MC Return on 2013-04-26

Cube Addon .xml cleanup:

Better plugin description.
Uppercase titles.
Improved tooltips and names.

Approved by PS Jenkins bot, Sam Spilsbury.