Compiz

Merge lp://qastaging/~compiz-team/compiz/compiz.fix_1186723 into lp://qastaging/compiz/0.9.10

  1. compiz.fix_1186723
  2. Merge into 0.9.10
Proposed by Sam Spilsbury
Status: Rejected
Rejected by: Sam Spilsbury
Proposed branch: lp://qastaging/~compiz-team/compiz/compiz.fix_1186723
Merge into: lp://qastaging/compiz/0.9.10
Diff against target: 249 lines (+105/-54)
2 files modified
gtk/window-decorator/tests/test_gwd_settings.cpp (+98/-51)
plugins/decor/src/decor.cpp (+7/-3)
To merge this branch: bzr merge lp://qastaging/~compiz-team/compiz/compiz.fix_1186723
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Needs Fixing
Sam Spilsbury Disapprove
Review via email: mp+167473@code.qastaging.launchpad.net

Commit message

Don't adjust windows with a static gravity for their decorations.

They will adjust themselves.

(LP: #1186723)

Description of the change

Don't adjust windows with a static gravity for their decorations.

They will adjust themselves.

(LP: #1186723)

Please test this, but don't merge it yet.

To post a comment you must log in.
Revision history for this message
MC Return (mc-return) wrote :

Well, I just tested the change in decor.cpp and it does not work here, *but* I am not sure if something with plugin loading from ~/.compiz-1/plugins has been broken recently...
I will soon now for sure...

Revision history for this message
MC Return (mc-return) wrote :

*know

Revision history for this message
Sam Spilsbury (smspillaz) wrote :

Never mind this one. I only just got unity compiled now and it seems like we really do have to adjust StaticGravity windows based on their decorations.

(Seriously, why can't guake just undecorate itself before mapping ... that would be so much easier ...)

Revision history for this message
Sam Spilsbury (smspillaz) :
review: Disapprove
Revision history for this message
MC Return (mc-return) wrote :

Yes, you are right -> plugin loading still works -> just retested to make sure...

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:3736
http://jenkins.qa.ubuntu.com/job/compiz-ci/190/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/compiz-gles-ci/./build=pbuilder,distribution=raring,flavor=amd64/231
    SUCCESS: http://jenkins.qa.ubuntu.com/job/compiz-saucy-amd64-ci/3
    FAILURE: http://jenkins.qa.ubuntu.com/job/compiz-saucy-armhf-ci/3/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/compiz-saucy-i386-ci/3

Click here to trigger a rebuild:
http://s-jenkins:8080/job/compiz-ci/190/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Sam Spilsbury (smspillaz) wrote :

I imagine that this will be folded into an unrevert of the relevant revision.

Revision history for this message
Sam Spilsbury (smspillaz) wrote :

Or not.

Unmerged revisions

3736. By Sam Spilsbury

Fixes LP #1186723

3735. By Sam Spilsbury

Don't adjust windows with a static gravity for their decorations.

They will adjust themselves.

(LP: #1168723)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: