Compiz

Merge lp://qastaging/~compiz-team/compiz/compiz.gsettings_tests.1 into lp://qastaging/compiz/0.9.8

  1. compiz.gsettings_tests.1
  2. Merge into 0.9.8
Proposed by Sam Spilsbury
Status: Superseded
Proposed branch: lp://qastaging/~compiz-team/compiz/compiz.gsettings_tests.1
Merge into: lp://qastaging/compiz/0.9.8
Diff against target: 1020 lines (+733/-112)
12 files modified
compizconfig/gsettings/CMakeLists.txt (+7/-1)
compizconfig/gsettings/gsettings_backend_shared/CMakeLists.txt (+15/-0)
compizconfig/gsettings/gsettings_backend_shared/gsettings_constants.c (+13/-0)
compizconfig/gsettings/gsettings_backend_shared/gsettings_shared.h (+24/-0)
compizconfig/gsettings/gsettings_backend_shared/gsettings_util.c (+187/-0)
compizconfig/gsettings/gsettings_backend_shared/gsettings_util.h (+37/-0)
compizconfig/gsettings/src/gsettings.c (+42/-90)
compizconfig/gsettings/src/gsettings.h (+3/-21)
compizconfig/gsettings/tests/CMakeLists.txt (+16/-0)
compizconfig/gsettings/tests/test_gsettings.cpp (+29/-0)
compizconfig/gsettings/tests/test_gsettings_tests.cpp (+319/-0)
compizconfig/gsettings/tests/test_gsettings_tests.h (+41/-0)
To merge this branch: bzr merge lp://qastaging/~compiz-team/compiz/compiz.gsettings_tests.1
Reviewer Review Type Date Requested Status
Compiz Maintainers Pending
Review via email: mp+113470@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2012-07-04.

This proposal has been superseded by a proposal from 2012-07-05.

Description of the change

Basic test fixtures for the GSettings backend for compiz, and some rudimentary tests which are WIP.

Not going to be a test for the whole thing ... we'll have to have some kind of meaningful way to split up the components of the backend to get them under test, GObject might be one way of doing that, as I have some code which can automatically generate tests for abstract GObject code.

To post a comment you must log in.
Revision history for this message
Sam Spilsbury (smspillaz) wrote : Posted in a previous version of this proposal

I'm putting this up for review now so I can get some feedback.

Revision history for this message
Sam Spilsbury (smspillaz) wrote :

LP seems to be showing conflicts even though there are really no conflicts..

Revision history for this message
Sam Spilsbury (smspillaz) wrote :

Random link errors :(

lp://qastaging/~compiz-team/compiz/compiz.gsettings_tests.1 updated
3286. By Sam Spilsbury

Fix merge markers and other build related things

3287. By Sam Spilsbury

Fix the include order

3288. By Sam Spilsbury

Check for 2.28

3289. By Sam Spilsbury

Merge lp:~compiz-team/compiz/compiz.compiz_discover_tests

3290. By Sam Spilsbury

Use compiz_discover_tests

3291. By Sam Spilsbury

Abstract include_directories through set ()

3292. By Sam Spilsbury

Put a message () there for debugging purpoes

3293. By Sam Spilsbury

Be more precise as to what we're debugging

3294. By Sam Spilsbury

Failing test case TestAppendToPluginsWithSetKeysListNewItem

3295. By Sam Spilsbury

Move the setup and teardown logic into another test fixture

3296. By Sam Spilsbury

Failing test TestAppendToPluginsWithSetKeysListExistingItem

3297. By Sam Spilsbury

Make the tests pass

3298. By Sam Spilsbury

Fix various build issues. We can't specify libcompizconfig in pkg_check_modules.

3299. By Sam Spilsbury

Merge lp:compiz

3300. By Sam Spilsbury

Test fixture CCSGSettingsTestGObjectListWithProperty.TestTest

3301. By Sam Spilsbury

Make the fixture return the fake gsettings object

3302. By Sam Spilsbury

Failing test TestFindExistingObjectWithSchema

3303. By Sam Spilsbury

Added should-be-failing test TestNoFindNonexistingObjectWithSchema

3304. By Sam Spilsbury

Make tests pass

3305. By Sam Spilsbury

Added a test fixture for handling the lossy gsettings key case

3306. By Sam Spilsbury

More test fixture and abstract out setting free into a destructor

3307. By Sam Spilsbury

Added failing test CCSGSettingsTestFindSettingLossy.TestFilterAvailableSettingsByType
and fix some problems in the mock code, adding a vfunc call for the destructor

3308. By Sam Spilsbury

Failing test CCSGSettingsTestFindSettingLossy.TestFilterAvailableSettingsMatchingPartOfStringIgnoringDashesUnderscoresAndCase

3309. By Sam Spilsbury

Remove useless function and make the first test pass cleanly

3310. By Sam Spilsbury

Make TestFilterAvailableSettingsMatchingPartOfStringIgnoringDashesUnderscoresAndCase pass

3311. By Sam Spilsbury

Failing test CCSGSettingsTestFindSettingLossy.TestAttemptToFindCCSSettingFromLossyNameSuccess

3312. By Sam Spilsbury

Make TestAttemptToFindCCSSettingFromLossyNameSuccess pass

3313. By Sam Spilsbury

Passing test TestAttemptToFindCCSSettingFromLossyNameFailTooMany

3314. By Sam Spilsbury

Passing test TestAttemptToFindCCSSettingFromLossyNameFailNoMatches

3315. By Sam Spilsbury

Set expectations correctly so that GTest is a bit quieter

3316. By Sam Spilsbury

Try and find a setting that matches the key ... add tests for variant
to matching CCSSettingType code

3317. By Sam Spilsbury

Make const char * constants const char * const

3318. By Sam Spilsbury

Fix memleak in the tests

3319. By Sam Spilsbury

Change the default paths to fall in line with gsettings requirements

3320. By Sam Spilsbury

Refactor the GSettings schema code, add a target to recompile
schemas on build on the schema generation area so that the tests
can read them.

3321. By Sam Spilsbury

Adjust CMake code so that GSettings schemas are only compiled locally once

3322. By Sam Spilsbury

Indirect GSettings schema installation so that environment variables
are not substituted at build time.

3323. By Sam Spilsbury

Indirect gschema install rule generation through separate function

3324. By Sam Spilsbury

Added wrappers around recompilation code to ensure it only gets
done once, and done last at install time

3325. By Daniel van Vugt

Fix build failure - Don't add a directory that doesn't exist (and hence
doesn't contain CMakeLists.txt).

3326. By Daniel van Vugt

Don't forget the log domain when splitting gsettings into multiple files.

3327. By Daniel van Vugt

Don't write to a "const char *" (poor use of strsep) !

3328. By Sam Spilsbury

Added postinst

3329. By Sam Spilsbury

Prevent possible buffer overflow

3330. By Daniel van Vugt

Fixed build failure (missing semicolon).

3331. By Daniel van Vugt

Fixed incorrectly formed paths. Also simplified and added tests.

3332. By Daniel van Vugt

Clean up paths: /org/freedesktop/compizconfig/ -> /org/freedesktop/compiz/

3333. By Daniel van Vugt

Remove unused globals

3334. By Daniel van Vugt

Change confusing COMPIZ_SCHEMA_ID to PLUGIN_SCHEMA_ID_PREFIX so its purpose
is more clear.

3335. By Daniel van Vugt

Remove unused global: CORE_NAME

3336. By Daniel van Vugt

Remove confusing "COMPIZ" global.

3337. By Daniel van Vugt

Simplify paths: <plugin>/screen<n>/options/ -> <plugin>/

3338. By Daniel van Vugt

Cleanup: Schema names should match the path. So renamed:
    org.freedesktop.compizconfig
    org.freedesktop.compizconfig.profile
to:
    org.freedesktop.compiz
    org.freedesktop.compiz.profile

Which also required renaming:
    org.freedesktop.compiz.gschema.xml
to:
    org.freedesktop.compiz.core.gschema.xml
which is what it's called internally anyway.

3339. By Daniel van Vugt

Moved:
    /org/freedesktop/compiz/<profile>/
to:
    /org/freedesktop/compiz/profiles/<profile>/
in order to reduce the risk of future namespace conflicts.

3340. By Daniel van Vugt

Fixed: plugins-with-set-keys appearing in two different locations, one of
which was wrong.

3341. By Daniel van Vugt

Remove the evil PATHNAME macro, at least for gsettings. Replace it with some
nicer functions.

3342. By Daniel van Vugt

Simplify gsettings from:
    org.freedesktop.compiz.*
   /org/freedesktop/compiz/*
to:
    org.compiz.*
   /org/compiz/*

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches