Merge lp://qastaging/~compiz-team/compiz/compiz.gtk-window-decorator-gsettings into lp://qastaging/compiz/0.9.8
Status: | Superseded | ||||
---|---|---|---|---|---|
Proposed branch: | lp://qastaging/~compiz-team/compiz/compiz.gtk-window-decorator-gsettings | ||||
Merge into: | lp://qastaging/compiz/0.9.8 | ||||
Diff against target: |
8500 lines (+6835/-913) 48 files modified
cmake/CompizGSettings.cmake (+8/-2) gtk/window-decorator/CMakeLists.txt (+70/-1) gtk/window-decorator/blurprops.c (+5/-2) gtk/window-decorator/cairo.c (+2/-2) gtk/window-decorator/decorator.c (+17/-33) gtk/window-decorator/events.c (+23/-10) gtk/window-decorator/frames.c (+7/-5) gtk/window-decorator/gtk-window-decorator.c (+52/-122) gtk/window-decorator/gtk-window-decorator.h (+22/-65) gtk/window-decorator/gwd-settings-interface.c (+162/-0) gtk/window-decorator/gwd-settings-interface.h (+102/-0) gtk/window-decorator/gwd-settings-notified-interface.c (+37/-0) gtk/window-decorator/gwd-settings-notified-interface.h (+63/-0) gtk/window-decorator/gwd-settings-notified.c (+264/-0) gtk/window-decorator/gwd-settings-notified.h (+37/-0) gtk/window-decorator/gwd-settings-storage-gconf.c (+387/-0) gtk/window-decorator/gwd-settings-storage-gconf.h (+55/-0) gtk/window-decorator/gwd-settings-storage-gsettings.c (+522/-0) gtk/window-decorator/gwd-settings-storage-gsettings.h (+84/-0) gtk/window-decorator/gwd-settings-storage-interface.c (+63/-0) gtk/window-decorator/gwd-settings-storage-interface.h (+66/-0) gtk/window-decorator/gwd-settings-writable-interface.c (+134/-0) gtk/window-decorator/gwd-settings-writable-interface.h (+142/-0) gtk/window-decorator/gwd-settings-xproperty-interface.c (+16/-0) gtk/window-decorator/gwd-settings-xproperty-interface.h (+51/-0) gtk/window-decorator/gwd-settings-xproperty-storage.c (+261/-0) gtk/window-decorator/gwd-settings-xproperty-storage.h (+39/-0) gtk/window-decorator/gwd-settings.c (+903/-0) gtk/window-decorator/gwd-settings.h (+41/-0) gtk/window-decorator/metacity.c (+59/-39) gtk/window-decorator/org.compiz.gwd.gschema.xml (+47/-0) gtk/window-decorator/settings.c (+76/-631) gtk/window-decorator/tests/CMakeLists.txt (+114/-0) gtk/window-decorator/tests/compiz_gwd_mock_settings.cpp (+186/-0) gtk/window-decorator/tests/compiz_gwd_mock_settings.h (+86/-0) gtk/window-decorator/tests/compiz_gwd_mock_settings_notified.cpp (+173/-0) gtk/window-decorator/tests/compiz_gwd_mock_settings_notified.h (+70/-0) gtk/window-decorator/tests/compiz_gwd_mock_settings_storage.cpp (+192/-0) gtk/window-decorator/tests/compiz_gwd_mock_settings_storage.h (+79/-0) gtk/window-decorator/tests/compiz_gwd_mock_settings_writable.cpp (+277/-0) gtk/window-decorator/tests/compiz_gwd_mock_settings_writable.h (+107/-0) gtk/window-decorator/tests/compiz_gwd_tests.h.in (+12/-0) gtk/window-decorator/tests/org.gnome.desktop.wm.preferences.gschema.xml (+72/-0) gtk/window-decorator/tests/org.gnome.mutter.gschema.xml (+20/-0) gtk/window-decorator/tests/test_gwd_settings.cpp (+1611/-0) gtk/window-decorator/wnck.c (+4/-1) include/decoration.h (+4/-0) libdecoration/decoration.c (+11/-0) |
||||
To merge this branch: | bzr merge lp://qastaging/~compiz-team/compiz/compiz.gtk-window-decorator-gsettings | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Daniel van Vugt | Needs Fixing | ||
Review via email:
|
This proposal has been superseded by a proposal from 2012-08-31.
Commit message
This branch transitions gtk-window-
1) Introduced three new interfaces (GWDSettingsNot
2) GWDSettingsStor
3) GWDSettingsWrit
4) GWDSettings is the main object for storing all settings in memory and provides an interface for them being written into
5) GWDSettingsNoti
Fixes LP #1042323
Yes I know the diff is huge.
If people don't want to do a formal review, thats fine, as I'm happy with the design as is. I will upload a coverage report and attach it to the bug.
Description of the change
This branch transitions gtk-window-
1) Introduced three new interfaces (GWDSettingsNot
2) GWDSettingsStor
3) GWDSettingsWrit
4) GWDSettings is the main object for storing all settings in memory and provides an interface for them being written into
5) GWDSettingsNoti
Fixes LP #1042323
Coverage: http:// people. canonical. com/~smspillaz/ coveragereports /compiz. gtk-window- decorator- gsettings/