Compiz

Merge lp://qastaging/~compiz-team/compiz/compiz.workaround_92599 into lp://qastaging/compiz/0.9.8

  1. compiz.workaround_92599
  2. Merge into 0.9.8
Proposed by Sam Spilsbury
Status: Merged
Approved by: Daniel van Vugt
Approved revision: 3388
Merged at revision: 3391
Proposed branch: lp://qastaging/~compiz-team/compiz/compiz.workaround_92599
Merge into: lp://qastaging/compiz/0.9.8
Diff against target: 157 lines (+44/-2)
5 files modified
plugins/composite/include/composite/composite.h (+2/-1)
plugins/composite/src/screen.cpp (+8/-1)
plugins/opengl/src/privates.h (+3/-0)
plugins/opengl/src/screen.cpp (+19/-0)
tests/manual/NVIDIAForceRefreshRate.txt (+12/-0)
To merge this branch: bzr merge lp://qastaging/~compiz-team/compiz/compiz.workaround_92599
Reviewer Review Type Date Requested Status
Daniel van Vugt Approve
jenkins (community) continuous-integration Approve
Review via email: mp+126224@code.qastaging.launchpad.net

Commit message

Workaround (LP: #92599) by forcing the user specified refresh rate on nvidia.

Description of the change

Workaround (LP: #92599) by forcing the user specified refresh rate on nvidia. There are no tests as I anticipate this feature will be removed once we hear about the correct way to handle this.

To post a comment you must log in.
Revision history for this message
jenkins (martin-mrazik+qa) wrote :

PASSED: Continuous integration, rev:3388
http://jenkins.qa.ubuntu.com/job/compiz-ci/122/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/compiz-ci/./build=pbuilder,distribution=quantal,flavor=amd64/122/console

review: Approve (continuous-integration)
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

No obvious regressions. I've only tested on intel though. Not Nvidia.

It's not important but I would have written:
    const bool forceRefreshRate = (pHnd ? pHnd->requiredForcedRefreshRate () : false);
as:
    const bool forceRefreshRate = pHnd && pHnd->requiredForcedRefreshRate ();
which is a little bit more readable.

What is important is this fix/workaround. Approved.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches