Merge lp://qastaging/~computergeoffrey/pantheon-photos/master into lp://qastaging/~pantheon-photos/pantheon-photos/trunk

Proposed by Geoffrey De Belie
Status: Merged
Approved by: Rico Tzschichholz
Approved revision: 3061
Merged at revision: 3067
Proposed branch: lp://qastaging/~computergeoffrey/pantheon-photos/master
Merge into: lp://qastaging/~pantheon-photos/pantheon-photos/trunk
Diff against target: 13 lines (+2/-1)
1 file modified
src/CollectionPage.vala (+2/-1)
To merge this branch: bzr merge lp://qastaging/~computergeoffrey/pantheon-photos/master
Reviewer Review Type Date Requested Status
Rico Tzschichholz Approve
Geoffrey De Belie (community) Needs Resubmitting
Review via email: mp+311326@code.qastaging.launchpad.net

Commit message

Fix for segmentation fault on right clicking a video file in the Photos Library

Description of the change

Crash fix for right clicking a video file

To post a comment you must log in.
Revision history for this message
Rico Tzschichholz (ricotz) wrote :

Simply add the new condition at first position of the exiting if-clause. So no need for an additional if-wrapper, therefore you get a *two-line* change

review: Needs Fixing
Revision history for this message
Geoffrey De Belie (computergeoffrey) wrote :

Done.

Revision history for this message
Geoffrey De Belie (computergeoffrey) wrote :

Not sure if I should change the status back to Resubmit.

review: Needs Resubmitting
Revision history for this message
Rico Tzschichholz (ricotz) wrote :

Squash this into one commit!

Fix the codestyle and actually look at the diff of this merge. So don't touch the other lines.

Revision history for this message
Geoffrey De Belie (computergeoffrey) wrote :

How would I do that?

What's wrong with the codestyle? I just don't understand what's wrong. Also, I haven't touched the other lines?

Revision history for this message
Geoffrey De Belie (computergeoffrey) wrote :

I merged this with the help of matzipan and donadigo. Looks good to me. I didn't know you used spaces instead of tabs, but now I do.

review: Needs Resubmitting
Revision history for this message
Rico Tzschichholz (ricotz) wrote :

What you actually want is:

Photo? photo = (get_view ().get_selected_at (0).get_source () as Photo);
if (photo != null && photo.get_master_file_format () == PhotoFileFormat.RAW) {
}

Revision history for this message
Geoffrey De Belie (computergeoffrey) wrote :

Tested. Should be fine.

review: Needs Resubmitting
3061. By Geoffrey De Belie

Fix for segmentation fault on right clicking a video file in the Photos Library

Revision history for this message
Rico Tzschichholz (ricotz) :
review: Approve
Revision history for this message
Zisu Andrei (matzipan) wrote :

Hey Geoffrey,

Make sure to set a commit message for your merge request (somewhere above "Description of the Change"). Once you set that, it will take 20 minutes and it will be merged automatically.

Revision history for this message
Geoffrey De Belie (computergeoffrey) wrote :

Done.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches