Merge lp://qastaging/~coreygoldberg/selenium-simple-test/grand-api-refactor into lp://qastaging/selenium-simple-test

Proposed by Corey Goldberg
Status: Merged
Approved by: Corey Goldberg
Approved revision: 221
Merged at revision: 221
Proposed branch: lp://qastaging/~coreygoldberg/selenium-simple-test/grand-api-refactor
Merge into: lp://qastaging/selenium-simple-test
Diff against target: 1650 lines (+399/-399)
35 files modified
docs/index.rst (+2/-2)
examples/googlefinance.py (+13/-13)
examples/seleniumhq.py (+2/-2)
examples/yahoofinance.py (+5/-5)
src/sst/actions.py (+64/-64)
src/sst/selftests/alerts.py (+16/-16)
src/sst/selftests/button.py (+26/-26)
src/sst/selftests/by_css.py (+1/-1)
src/sst/selftests/by_xpath.py (+1/-1)
src/sst/selftests/checkbox.py (+23/-23)
src/sst/selftests/click.py (+6/-6)
src/sst/selftests/current_url.py (+2/-2)
src/sst/selftests/data_driven_form.py (+6/-6)
src/sst/selftests/exists_element.py (+1/-1)
src/sst/selftests/file_input.py (+5/-5)
src/sst/selftests/get_element.py (+23/-23)
src/sst/selftests/get_element_fails.py (+2/-2)
src/sst/selftests/html5.py (+13/-13)
src/sst/selftests/is_displayed.py (+7/-7)
src/sst/selftests/keys.py (+4/-4)
src/sst/selftests/link.py (+23/-23)
src/sst/selftests/no_js.py (+2/-2)
src/sst/selftests/radio.py (+34/-34)
src/sst/selftests/select.py (+11/-11)
src/sst/selftests/source.py (+1/-1)
src/sst/selftests/switch_to_frame.py (+8/-8)
src/sst/selftests/switch_to_window.py (+10/-10)
src/sst/selftests/text.py (+6/-6)
src/sst/selftests/textfield.py (+23/-23)
src/sst/selftests/title.py (+20/-20)
src/sst/selftests/unicode.py (+10/-10)
src/sst/selftests/url_contains.py (+5/-5)
src/sst/selftests/waitfor.py (+17/-17)
src/sst/selftests/window_close.py (+5/-5)
src/sst/selftests/yui.py (+2/-2)
To merge this branch: bzr merge lp://qastaging/~coreygoldberg/selenium-simple-test/grand-api-refactor
Reviewer Review Type Date Requested Status
Corey Goldberg (community) Approve
Leo Arias (community) code review, tests executed Approve
Review via email: mp+84829@code.qastaging.launchpad.net

Commit message

the grand API renaming/refactor

Description of the change

the grand API renaming/refactor!

the following public actions (function) names have been changed in SST:

old_name -> new_name
-----------------------------------
alert_accept -> accept_alert
alert_dismiss -> dismiss_alert
button_click -> click_button
checkbox_set -> set_checkbox_value
checkbox_toggle -> toggle_checkbox
checkbox_value_is -> assert_checkbox_value
element_click -> click_element
goto -> go_to
is_button -> assert_button
is_checkbox -> assert_checkbox
is_displayed -> assert_displayed
is_link -> assert_link
is_radio -> assert_radio
is_select -> assert_dropdown
is_textfield assert_textfield
link_click -> click_link
radio_select -> set_radio_value
radio_value_is -> assert_radio_value
select_value_is -> assert_dropdown_value
set_select -> set_dropdown_value
text_contains -> assert_text_contains
text_is -> assert_text
textfield_write -> write_textfield
title_contains -> assert_title_contains
title_is -> assert_title
url_contains -> assert_url_contains
url_is -> assert_url
waitfor -> wait_for
window_close -> close_window

To post a comment you must log in.
Revision history for this message
Corey Goldberg (coreygoldberg) wrote :

the current public API is now:

--------
accept_alert
assert_button
assert_checkbox
assert_checkbox_value
assert_dropdown
assert_dropdown_value
assert_link
assert_radio
assert_radio_value
assert_select
assert_text
assert_text_contains
assert_textfield
assert_title
assert_title_contains
assert_url
assert_url_contains
click_button
click_element
click_link
close_window
debug
dismiss_alert
end_test
exists_element
fails
get_argument
get_base_url
get_current_url
get_element
get_element_by_css
get_element_by_xpath
get_elements
get_elements_by_css
get_elements_by_xpath
get_link_url
get_page_source
go_to
reset_base_url
run_test
set_base_url
set_checkbox_value
set_dropdown_value
set_radio_value
set_wait_timeout
simulate_keys
skip
sleep
start
stop
switch_to_frame
switch_to_window
take_screenshot
toggle_checkbox
wait_for
write_textfield

Revision history for this message
Leo Arias (elopio) wrote :

Code reviewed and tests run. Approved!
This is great, thanks Corey.

review: Approve (code review, tests executed)
Revision history for this message
Corey Goldberg (coreygoldberg) wrote :

ok for merge

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches