Merge lp://qastaging/~coreygoldberg/selenium-simple-test/selftests-no-nose into lp://qastaging/selenium-simple-test
Proposed by
Corey Goldberg
| Status: | Merged |
|---|---|
| Merged at revision: | 421 |
| Proposed branch: | lp://qastaging/~coreygoldberg/selenium-simple-test/selftests-no-nose |
| Merge into: | lp://qastaging/selenium-simple-test |
| Diff against target: |
200 lines (+32/-34) 7 files modified
ci.sh (+2/-12) src/sst/scripts/test.py (+6/-4) src/sst/tests/__init__.py (+7/-1) src/sst/tests/test_code_format.py (+2/-0) src/sst/tests/test_django_devserver.py (+12/-8) tox-acceptance.ini (+1/-6) tox.ini (+2/-3) |
| To merge this branch: | bzr merge lp://qastaging/~coreygoldberg/selenium-simple-test/selftests-no-nose |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Vincent Ladeuil (community) | Needs Fixing | ||
|
Review via email:
|
|||
Commit message
remove nose and add use sst-test
Description of the change
this MP removes nose as a dependency for running self unit tests.
sst-test runs all unit and acceptance tests.
to run all tests:
$ ./ci.sh --bootstrap --acceptance
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
54 + excludes = [r'^sst\.\w*$', r'^sst\.scripts\.']
excludes are meant to exclude valid tests not control loading. You're lucky
there is no side effects in all sst modules nor scripts.
55 + shared_directory = os.path.join('.', 'sst', 'selftests', 'shared')
This will break if not run from the root directory, 'test_dir' a few lines
below relies on 'os.chdir(
start in the right directory.
74 - excludes=
75 + excludes=excludes
You're hijacking the --exclude parameter, user should still be able to use
it.
See https:/
119 +# sst.DEVSERVER_PORT is already in used when sst-test is running,
120 +# so defining another port here for unit testing.
121 +DEVSERVER_PORT = '8130'
Yet another workaround for not being able to better control django's port :-/
128 - tests.set_
Why do you remove this ?