Merge lp://qastaging/~coreygoldberg/selenium-simple-test/update-unit-findcases into lp://qastaging/selenium-simple-test
Proposed by
Corey Goldberg
| Status: | Merged |
|---|---|
| Approved by: | Corey Goldberg |
| Approved revision: | 390 |
| Merged at revision: | 387 |
| Proposed branch: | lp://qastaging/~coreygoldberg/selenium-simple-test/update-unit-findcases |
| Merge into: | lp://qastaging/selenium-simple-test |
| Prerequisite: | lp://qastaging/~coreygoldberg/selenium-simple-test/fixed-acceptance-imports |
| Diff against target: |
93 lines (+16/-18) 1 file modified
src/sst/tests/test_runtests_find_cases.py (+16/-18) |
| To merge this branch: | bzr merge lp://qastaging/~coreygoldberg/selenium-simple-test/update-unit-findcases |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Leo Arias (community) | code review | Approve | |
|
Review via email:
|
|||
Commit message
updated unit tests for find-cases
Description of the change
updated unit tests for find-cases.
Python 3 deprecates "assertItemsEqual", which we used in some unit tests.
I changed these to "assertSetEquals", so they are more compatible when we port to Py3.
this also makes the tests more explicit, since these are sets.
To post a comment you must log in.
Revision history for this message
| Leo Arias (elopio) | # |
review:
Approve
(code review)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
