Merge lp://qastaging/~cosmos-door/unity/fix-preedit-663776 into lp://qastaging/unity
Proposed by
Mitsuya Shibata
| Status: | Merged |
|---|---|
| Merged at revision: | 1665 |
| Proposed branch: | lp://qastaging/~cosmos-door/unity/fix-preedit-663776 |
| Merge into: | lp://qastaging/unity |
| Diff against target: |
73 lines (+37/-0) 1 file modified
plugins/unityshell/src/IMTextEntry.cpp (+37/-0) |
| To merge this branch: | bzr merge lp://qastaging/~cosmos-door/unity/fix-preedit-663776 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Neil J. Patel (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
Fix unvisible pre-edit text in Dash with iBus.
https:/
How to reproduce:
1. Open Dash.
2. Startup Input Method(in Japanese, press Ctrl+Space)
-> emit signal "preedit-start"
3. Type 'a', preedit text should be render, but dont
-> emit signal "preedit-changed"
4. Press Enter, preedit text is fixed
-> emit signal "commit", and render text in Dash
In code:
OnCommit signal handler call SetText, then text is rendered.
However OnPreeditChanged signal handler do nothing.
This branch add code to render preedit text in OnPreeditChanged.
And at OnCommit, remove preedit text, and reset cursor position.
To post a comment you must log in.
Revision history for this message
| Mitsuya Shibata (cosmos-door) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Please refer comments since #71 in LP: #663776