Granite

Merge lp://qastaging/~coucouf/granite/timepicker-minutes-hour-patch into lp://qastaging/~elementary-pantheon/granite/granite

  1. timepicker-minutes-hour-patch
  2. Merge into granite
Proposed by Aurélien COUDERC
Status: Merged
Approved by: Cody Garver
Approved revision: 528
Merged at revision: 586
Proposed branch: lp://qastaging/~coucouf/granite/timepicker-minutes-hour-patch
Merge into: lp://qastaging/~elementary-pantheon/granite/granite
Diff against target: 23 lines (+0/-6)
1 file modified
lib/Widgets/TimePicker.vala (+0/-6)
To merge this branch: bzr merge lp://qastaging/~coucouf/granite/timepicker-minutes-hour-patch
Reviewer Review Type Date Requested Status
elementary UX Pending
elementary Pantheon team Pending
Review via email: mp+146264@code.qastaging.launchpad.net

Commit message

[TimePicker] Leave DateTime add or substract 1 hour when cycling around 60 minutes.

Description of the change

Corrects the following inconsistent behaviour in Maya :
- set minutes to 55, e.g. 9H55
- add minutes (minutes are added by 5)

Current result :
- 9H00

Result with patch :
- 10H00

Same for substracting minutes to 00 : 9H00, substract minutes should lead to 8H55.

To post a comment you must log in.
Revision history for this message
Sergey "Shnatsel" Davidoff (shnatsel) wrote :

It works for me in granite-demo and Maya.
Maya's "New event" dialog now works a bit awkwardly because rolling over the 24h doesn't change the date in date pickers, but that's OK.

Revision history for this message
Aurélien COUDERC (coucouf) wrote :

Le 02/02/2013 15:47, Sergey "Shnatsel" Davidoff a écrit :
> It works for me in granite-demo and Maya.
> Maya's "New event" dialog now works a bit awkwardly because rolling over the 24h doesn't change the date in date pickers, but that's OK.
 Yes, that (rolling dates) will hopefully be my next patch. :-)

Revision history for this message
Victor Martinez (victored) wrote :

The code changes look safe. The behavior introduced by this patch is also nicer IMO

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches