Merge lp://qastaging/~cprov/launchpad/strict-usernames into lp://qastaging/launchpad
| Status: | Needs review |
|---|---|
| Proposed branch: | lp://qastaging/~cprov/launchpad/strict-usernames |
| Merge into: | lp://qastaging/launchpad |
| Diff against target: |
674 lines (+179/-77) 17 files modified
lib/lp/app/validators/name.py (+63/-0) lib/lp/bugs/browser/tests/test_bugtarget_filebug.py (+3/-3) lib/lp/bugs/doc/bugsummary.txt (+4/-4) lib/lp/bugs/doc/bugtracker-person.txt (+1/-2) lib/lp/bugs/model/bugtracker.py (+12/-3) lib/lp/bugs/model/tests/test_bugsubscriptioninfo.py (+2/-2) lib/lp/code/model/tests/test_branchlookup.py (+21/-21) lib/lp/code/model/tests/test_gitlookup.py (+9/-9) lib/lp/registry/browser/tests/test_person.py (+20/-0) lib/lp/registry/browser/tests/test_team.py (+4/-2) lib/lp/registry/doc/person.txt (+2/-2) lib/lp/registry/interfaces/person.py (+6/-3) lib/lp/registry/model/person.py (+7/-7) lib/lp/registry/tests/test_nickname.py (+4/-4) lib/lp/registry/tests/test_notification.py (+10/-10) lib/lp/services/database/tests/test_transaction_policy.py (+2/-1) lib/lp/translations/stories/standalone/xx-person-activity.txt (+9/-4) |
| To merge this branch: | bzr merge lp://qastaging/~cprov/launchpad/strict-usernames |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Celso Providelo (community) | Disapprove | ||
| Colin Watson (community) | Needs Fixing | ||
|
Review via email:
|
|||
Commit message
Setting stricter restrictions for LP usernames.
Description of the change
This is part of wider effort to have cleaner usernames across all Canonical services.
https:/
The current goal is to stop new users to get in with "unclean" names. SSO already forces clean names for new users, with this MP so will LP.
Next we will introduce a way to allow Store users to pick a alternative "clean" username and eventually switch to it.
| Colin Watson (cjwatson) | # |
| Colin Watson (cjwatson) | # |
Unmerged revisions
- 18961. By Celso Providelo
-
Ensure legacy username field is not omitted in test.
- 18960. By Celso Providelo
-
Extend IBugTracker.
ensurePersonFor Self() to perform extra text mangling to fit into the 32-char username limit. - 18959. By Celso Providelo
-
Mechanical test fixes, len(username) >= 3
- 18958. By Celso Providelo
-
Legacy usernames do not block account details changes.
- 18957. By Celso Providelo
-
Stricter (and tastier) LP usernames.
There is a less intrusive approach to prevent 'unclean' usernames in https:/