Merge lp://qastaging/~csurbhi/ubuntu/natty/mountall/mountall.timeout into lp://qastaging/ubuntu/natty/mountall
| Status: | Merged |
|---|---|
| Merge reported by: | Bryce Harrington |
| Merged at revision: | not available |
| Proposed branch: | lp://qastaging/~csurbhi/ubuntu/natty/mountall/mountall.timeout |
| Merge into: | lp://qastaging/ubuntu/natty/mountall |
| Diff against target: |
298 lines (+162/-3) 1 file modified
src/mountall.c (+162/-3) |
| To merge this branch: | bzr merge lp://qastaging/~csurbhi/ubuntu/natty/mountall/mountall.timeout |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Bryce Harrington | Approve | ||
| Ubuntu branches | Pending | ||
|
Review via email:
|
|||
Description of the change
Introducing a mountall option "timeout" for a _local_ filesystem.
** Reasons for the change:
-------
* mountall waits endlessly for a device to get ready before mounting a filesystem if "nobootwait" is not explicitly mentioned in /etc/fstab. In case of a local device it makes sense to bound this waiting period by the maximum time it takes for the underlying bus to scan a device. Currently there is no way of specifying this maximum time that mountall should wait for a device to be configured before triggering a recovery process. A recovery process could involve configuring the stacked sub devices. For example: In case of a lvm device which is configured on an underlying raid device, recovery could mean starting the raid device in a degraded mode in case one of the member device does not turn up.
* This "timeout" option needs to be mentioned in /etc/fstab. It indicates that by default mountall will wait for 30 seconds for a device to be configured successfully, after which it emits an upstart event "device-not-ready" if the device is not configured yet. Upstart jobs started on this event could handle the device configuration.
* The default timeout of 30 seconds can be changed through a command line option dev_wait_time. The legal values for dev_wait_time lie between 1 second to 2147483647 seconds.
* "timeout" will have no effect if "nobootwait" is specified. This means that "nobootwait" cancels "timeout" effect.
* This change is necessary for using mountall to mount the root filesystem "ro". In this case we do not wish to wait endlessly for the root device to appear.
** Side effects:
----------------
This change should not affect the current functioning of mountall if "timeout" option is not specified in /etc/fstab.
Please do consider this change for merging.
Hi Surbhi,
Change looks good, builds fine. I've packaged and uploaded it, and merged it to bzr trunk.
It appears this will fix bug #595904 so I've set this as the fix for that. (It is good to associate patches you're proposing to a bug #, for tracking purposes, especially in these final weeks before release).