Merge lp://qastaging/~cszikszoy/do/proxy into lp://qastaging/do
Proposed by
Chris S.
| Status: | Work in progress | ||||
|---|---|---|---|---|---|
| Proposed branch: | lp://qastaging/~cszikszoy/do/proxy | ||||
| Merge into: | lp://qastaging/do | ||||
| Diff against target: |
421 lines (+210/-18) 10 files modified
Do.Platform.Linux/src/Do.Platform/Do.Platform.Linux/GConfPreferencesService.cs (+29/-4) Do.Platform.Linux/src/Do.Platform/Do.Platform.Linux/NetworkService.cs (+108/-4) Do.Platform/src/Do.Platform/Do.Platform.Common/DictionaryPreferencesService.cs (+15/-5) Do.Platform/src/Do.Platform/Do.Platform.Default/NetworkService.cs (+7/-0) Do.Platform/src/Do.Platform/Do.Platform.Default/PreferencesService.cs (+13/-1) Do.Platform/src/Do.Platform/Do.Platform.Preferences/PreferencesImplementation.cs (+16/-3) Do.Platform/src/Do.Platform/INetworkService.cs (+2/-0) Do.Platform/src/Do.Platform/IPreferences.cs (+3/-0) Do.Platform/src/Do.Platform/IPreferencesService.cs (+3/-0) Do.Platform/src/Do.Platform/SecurePreferencesWrapper.cs (+14/-1) |
||||
| To merge this branch: | bzr merge lp://qastaging/~cszikszoy/do/proxy | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Chris Halse Rogers | Needs Information | ||
|
Review via email:
|
|||
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
I'd prefer it if there weren't whitespace changes mixed in here, but I know that can be difficult to do.
If I understand this code correctly, you've extended the Preferences service to also handle system-wide preferences. I'm not sure how good an idea this is - could we instead have something like a SystemConfiguration service that would deal with this sort of system-wide configuration? An advantage I see from that is that the proxy configuration work could get factored out into a platform-neutral place - the proxy setting code is platform independent.
That would also remove the somewhat smelly AddNotify/