Merge lp://qastaging/~cszikszoy/docky/proxydocky into lp://qastaging/docky

Proposed by Chris S.
Status: Merged
Merged at revision: 1296
Proposed branch: lp://qastaging/~cszikszoy/docky/proxydocky
Merge into: lp://qastaging/docky
Diff against target: 362 lines (+158/-29)
9 files modified
Docky.Services/Docky.Services/DockServices.cs (+5/-0)
Docky.Services/Docky.Services/IPreferences.cs (+3/-0)
Docky.Services/Docky.Services/Preferences.cs (+20/-0)
Docky.Services/Docky.Services/SystemService.cs (+74/-3)
Docky/Docky/Docky.cs (+2/-1)
StandardPlugins/GMail/src/GMailAtom.cs (+15/-10)
StandardPlugins/NPR/src/NPR.cs (+19/-0)
StandardPlugins/NPR/src/Station.cs (+16/-12)
StandardPlugins/Weather/src/Sources/AbstractWeatherSource.cs (+4/-3)
To merge this branch: bzr merge lp://qastaging/~cszikszoy/docky/proxydocky
Reviewer Review Type Date Requested Status
Robert Dyer (community) Needs Information
Review via email: mp+22274@code.qastaging.launchpad.net

Description of the change

add proxy support and update all docklets to use proxy settings.

To post a comment you must log in.
Revision history for this message
Chris S. (cszikszoy) wrote :

Ignore lines 55-58 of the diff. That was just there for debug. I've already removed that in my branch. It's now just:
return GConf.Get<bool> ("/system/http_proxy/use_http_proxy", false);

1214. By Chris S.

remove some debug

Revision history for this message
Robert Dyer (psybers) wrote :

Looks good!

My only comment is I wonder if we can cache the proxy settings and then only update them if gconf changes? As it is now, every web request will incur like 3 calls to gconf (assuming there is a proxy), which means if you have weather setup for every 15 mins, gmail for every 2 mins with 4 labels, npr, etc... you will have a *lot* of calls to gconf which probably arent needed!

I seem to recall the example in the bug report cached. ;-)

review: Needs Information
Revision history for this message
Chris S. (cszikszoy) wrote :

> Looks good!
>
> My only comment is I wonder if we can cache the proxy settings and then only
> update them if gconf changes?

It would be really nice if we could do this. We don't have any sort of way to monitor GConf for changes as of right now. Any ideas how we could do that cleanly?

Revision history for this message
Robert Dyer (psybers) wrote :

I put code into GNOME Do that did that, take a look there how it is done. Basically you can tell gconf to notify you when a certain path changes.

1215. By Chris S.

cache proxy settings, update when gconf key changes

1216. By Chris S.

remove debug

1217. By Chris S.

make sure the notification handler gets removed on exit

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: