Merge curtin:usage-json-double-quotes into curtin:master

Proposed by Olivier Gayot
Status: Merged
Approved by: Michael Hudson-Doyle
Approved revision: 4afe6d3822a9a2a9720ebc63e470c31865f2467a
Merge reported by: Server Team CI bot
Merged at revision: not available
Proposed branch: curtin:usage-json-double-quotes
Merge into: curtin:master
Diff against target: 26 lines (+2/-2)
2 files modified
curtin/commands/install.py (+1/-1)
curtin/commands/main.py (+1/-1)
Reviewer Review Type Date Requested Status
Server Team CI bot continuous-integration Approve
Michael Hudson-Doyle Approve
Review via email: mp+427169@code.qastaging.launchpad.net

Commit message

usage: fix help that showed invalid JSON in examples

The usage showed examples to override the stages that are
executed when running curtin install. That said, JSON only
accepts strings surrounded by double quotes and the examples use
single quotes. This leads to invalid JSON syntax if the examples
are copied.

Fixed by inverting the quotes used in the examples so that the
examples are valid.

Description of the change

usage: fix help that showed invalid JSON in examples

The usage showed examples to override the stages that are executed when running curtin install. That said, JSON only accepts strings surrounded by double quotes and the examples use single quotes. This leads to invalid JSON syntax if the examples are copied.

Fixed by inverting the quotes used in the examples so that the examples are valid.

To post a comment you must log in.
Revision history for this message
Server Team CI bot (server-team-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

thanks

review: Approve
Revision history for this message
Server Team CI bot (server-team-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Server Team CI bot (server-team-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Server Team CI bot (server-team-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Server Team CI bot (server-team-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Server Team CI bot (server-team-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Server Team CI bot (server-team-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Server Team CI bot (server-team-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :
Revision history for this message
Olivier Gayot (ogayot) wrote :

> https://code.launchpad.net/~mwhudson/curtin/+git/curtin/+merge/427468 might
> help with the CI

Thanks for doing this!

Revision history for this message
Server Team CI bot (server-team-bot) :
review: Approve (continuous-integration)
Revision history for this message
Server Team CI bot (server-team-bot) wrote :

Commit message lints:
- Line #2 has 184 too many characters. Line starts with: "The usage showed examples"...- Line #4 has 8 too many characters. Line starts with: "Fixed by inverting the"...

review: Needs Fixing
Revision history for this message
Server Team CI bot (server-team-bot) :
review: Approve (continuous-integration)

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches