Merge lp://qastaging/~cv.clearcorp/openobject-server/lp-970538-timezone into lp://qastaging/openobject-server/6.1
Proposed by
Carlos Vásquez (ClearCorp)
| Status: | Work in progress |
|---|---|
| Proposed branch: | lp://qastaging/~cv.clearcorp/openobject-server/lp-970538-timezone |
| Merge into: | lp://qastaging/openobject-server/6.1 |
| Diff against target: |
13 lines (+3/-0) 1 file modified
openerp-server (+3/-0) |
| To merge this branch: | bzr merge lp://qastaging/~cv.clearcorp/openobject-server/lp-970538-timezone |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Olivier Dony (Odoo) | tech analysis | Disapprove | |
|
Review via email:
|
|||
Description of the change
The server timezone is not set to timezone config value when it's set.
To post a comment you must log in.
Revision history for this message
| Olivier Dony (Odoo) (odo-openerp) wrote | # |
review:
Disapprove
(tech analysis)
Unmerged revisions
- 4133. By Carlos Vásquez (ClearCorp)
-
[FIX] set server timezone from config value
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Hello Carlos,
You merge proposal is clean, but unfortunately I have to disagree with the patch.
It is a design choice in OpenERP 6.1 to forcefully set the server timezone to UTC at all times and ignore the previous --timezone configuration parameter. There are many good reasons for this, and you may find some further explanations about them in related bug reports: bug 918257 (especially comment #4) and further technical discussions in bug 925361.
I understand that this may look like a bug because the --timezone option was not removed and does not report a warning when you try to use it. Perhaps you could update your merge proposal to have the server issue a warning when the config['timezone'] value is set to a non-UTC value, to let the admin know that the config value is ignored...?
I'll put the merge proposal in "Work in Progress" state, feel free to set it as "Needs Review" again after you update it, or to delete it altogether if you don't plan on working on it anymore (or make a different one)
Thanks for contributing to OpenERP!