Code review comment for lp://qastaging/~cyphermox/libdbusmenu/inline

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Awesome work!

Just a small remark:
I see some Breaks:, which seems not valid anymore in our upgrade path (as precise have newer versions that those), can you check every of them and remove if they not needed (meaning right now, if precise has a higher or equal version than the break)

Also, the tests seems to be built, but not run automatically? Can you have a look why.

Once the 2 items are done or have an answer, feel free to get it merged without waiting for me (hence the approval). Good work again :)

review: Approve

« Back to merge proposal