Merge lp://qastaging/~cypressyew/cdts/sync-graphic-job into lp://qastaging/cdts

Proposed by Po-Hsu Lin
Status: Merged
Approved by: Zygmunt Krynicki
Approved revision: 60
Merged at revision: 59
Proposed branch: lp://qastaging/~cypressyew/cdts/sync-graphic-job
Merge into: lp://qastaging/cdts
Diff against target: 85 lines (+26/-15)
1 file modified
plainbox-provider-canonical-driver-test-suite/units/ihv-graphics.pxu (+26/-15)
To merge this branch: bzr merge lp://qastaging/~cypressyew/cdts/sync-graphic-job
Reviewer Review Type Date Requested Status
Zygmunt Krynicki (community) Approve
Po-Hsu Lin Needs Resubmitting
Sylvain Pineau Pending
Chris Gregan Pending
Review via email: mp+258581@code.qastaging.launchpad.net

Description of the change

This patch includes those newly landed hybrid graphic tests, also the thunderbolt test. But it's not a 100% migration.

For Thunderbolt tests, I didn't see similar HDMI audio and Firewire storage test anywhere in CDTS provider, therefore I didn't add the playback, storage and daisy chain test.

For other graphic-related tests, I didn't put the monitor audio test as it looks like they're intended to be not included.

To post a comment you must log in.
60. By Po-Hsu Lin

providers:cdts: rename the display test into video test

Revision history for this message
Po-Hsu Lin (cypressyew) wrote :

Resubmitted to include the recent display job name change
https://code.launchpad.net/~cypressyew/checkbox/display-rename/+merge/259351

review: Needs Resubmitting
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

12:27 <@zyga> PHLin: hey, about https://code.launchpad.net/~cypressyew/cdts/sync-graphic-job/+merge/258581
12:28 <@zyga> PHLin: I see that driver_version is gone
12:28 <@zyga> PHLin: is that deliberate?
12:28 < PHLin> zyga, checking
12:28 <@zyga> h
12:28 <@zyga> ah, I see it was already there in a _* version
12:28 < PHLin> zyga, yes
12:29 < PHLin> zyga, ah
12:29 < PHLin> zyga, I think this needs to be sync again
12:29 < PHLin> zyga, as we're adding some before suspend tests to after suspend
12:29 < PHLin> zyga, do you want me to rebase this revision or patch it later?
12:30 <@zyga> PHLin: as you wish
12:30 <@zyga> PHLin: I'm fine with merging this now
12:30 < PHLin> zyga, ok then, I think we could merge this first
12:31 < PHLin> zyga, it will make it easier to compare

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches