Checkbox

Merge lp://qastaging/~cypressyew/checkbox/modify_dim_description into lp://qastaging/checkbox

modify_dim_description
Merge into trunk

Proposed by Po-Hsu Lin on 2013-04-18

Status:

Merged

Approved by:

Daniel Manrique on 2013-04-18

Approved revision:

2053

Merged at revision:

2057

Proposed branch:

lp://qastaging/~cypressyew/checkbox/modify_dim_description

Merge into:

lp://qastaging/checkbox

Diff against target:

29 lines (+7/-3)

2 files modified

debian/changelog (+4/-0)
jobs/monitor.txt.in (+3/-3)

To merge this branch:

bzr merge lp://qastaging/~cypressyew/checkbox/modify_dim_description

Low

Fix Released

Link a bug report

Reviewer	Date Requested	Status
Daniel Manrique (community)		Approve on 2013-04-18
Brendan Donegan (community)	2013-04-18	Needs Fixing on 2013-04-18
Review via email: mp+159539@code.qastaging.launchpad.net

Description of the change

According to scripts/brightness_test, the dim_brightness test will set the brightness to the half of the maximum value.

# Set the brightness to half the max value
brightness.write_value(max_brightness / 2, os.path.join(interface, 'brightness'))

But in the description file (jobs/monitor.txt.in), it wrote:
"Check if the screen was dimmed approximately by half."

When the tester is using the lower-then-half brightness, this test will bring the brightness UP thus may cause some confusions.

Revision history for this message

Brendan Donegan (brendan-donegan) wrote on 2013-04-18:

s/the half/half/g

review: Needs Fixing

Revision history for this message

Brendan Donegan (brendan-donegan) wrote on 2013-04-18:

Please add a debian/changelog entry too, thanks!

review: Needs Fixing

lp://qastaging/~cypressyew/checkbox/modify_dim_description updated on 2013-04-18

2053. By Po-Hsu Lin on 2013-04-18: Add a entry in debian/changelog, and modify the description.

Revision history for this message

Daniel Manrique (roadmr) wrote on 2013-04-18:

Looks good!

I also notice you filed a bug about this, and added a changelog entry. If, next time, you follow these steps, Launchpad will link the bug with the branch and set it to fix released automatically once it goes into a published package:

1- File the bug
2- Prepare the fix, and add a changelog entry with the bug number formatted as (LP: #1234567)
3- You can either bzr commit --fixes=lp:1234567 *or* simply run debcommit (in the devscripts package), which will do a commit with the changelog entry as message and linking all the fixed bugs.
4- WHen you push, the bugs will be automatically linked to the merge request