cloud-init

Merge lp://qastaging/~d-jj/cloud-init/chef-12-updates into lp://qastaging/~cloud-init-dev/cloud-init/trunk

  1. chef-12-updates
  2. Merge into trunk
Proposed by JJ Asghar
Status: Rejected
Rejected by: Scott Moser
Proposed branch: lp://qastaging/~d-jj/cloud-init/chef-12-updates
Merge into: lp://qastaging/~cloud-init-dev/cloud-init/trunk
Diff against target: 178 lines (+81/-42)
2 files modified
doc/examples/cloud-config-chef.txt (+77/-41)
templates/chef_client.rb.tmpl (+4/-1)
To merge this branch: bzr merge lp://qastaging/~d-jj/cloud-init/chef-12-updates
Reviewer Review Type Date Requested Status
JJ Asghar (community) Approve
Review via email: mp+262266@code.qastaging.launchpad.net

Description of the change

This is to update the Chef examples and changes for the newer/est ways
Chef is converting to. Omnibus is now the default installation method, but
there are also more up-to-date package repos at packagecloud.io if the user
still wants to install the deb package.

I have also added the encrypted_data_bag option to the client.rb being that
it is a useful option to have for more secure environments.

To post a comment you must log in.
Revision history for this message
JJ Asghar (d-jj) :
review: Approve
Revision history for this message
JJ Asghar (d-jj) wrote :

I have signed the Canonical Contributors license, and been approved. Is there anything else i need to get this merged?

Revision history for this message
Scott Moser (smoser) wrote :

Hi JJ,
 Sorry for the very slow reply.

 Almost all nit picks inline below.

Thanks for your suggestion,
If you have further questions, please join #cloud-init on Freenode and poke me (smoser).

Revision history for this message
Scott Moser (smoser) wrote :

Hello,
Thank you for taking the time to contribute to cloud-init. Cloud-init has moved its revision control system to git. As a result, we are marking all bzr merge proposals as 'rejected'. If you would like to re-submit this proposal for review, please do so by following the current HACKING documentation at http://cloudinit.readthedocs.io/en/latest/topics/hacking.html .

I believe portions of this might be upstream at this point, see commits
 https://git.launchpad.net/cloud-init/commit/?id=482b2746b5919233
 https://git.launchpad.net/cloud-init/commit/?id=291d2976bd7b

Revision history for this message
JJ Asghar (d-jj) wrote :

Awesome, i've gone ahead and updated: https://code.launchpad.net/~d-jj/cloud-init/+git/cloud-init/+merge/325136

Unmerged revisions

1075. By JJ Asghar

i hate whitespace issues

1074. By JJ Asghar

WS removal

1073. By JJ Asghar

fixed up per Matt Rays suggestions and catches

1072. By JJ Asghar

updated for chef 12 and packagecloud.io changes and also converted to omnibus as the defacto standard to install chef

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.