Merge lp://qastaging/~daker/loco-team-portal/fix.1542697 into lp://qastaging/loco-team-portal
Proposed by
Adnane Belmadiaf
| Status: | Needs review | ||||
|---|---|---|---|---|---|
| Proposed branch: | lp://qastaging/~daker/loco-team-portal/fix.1542697 | ||||
| Merge into: | lp://qastaging/loco-team-portal | ||||
| Diff against target: |
25 lines (+2/-2) 2 files modified
Makefile (+1/-1) loco_directory/articles/models.py (+1/-1) |
||||
| To merge this branch: | bzr merge lp://qastaging/~daker/loco-team-portal/fix.1542697 | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Lucy Llewellyn (community) | Needs Fixing | ||
| Chris Johnston | Approve | ||
|
Review via email:
|
|||
Commit message
Fixed feed date parsing
Description of the change
Fixed feed date parsing
To post a comment you must log in.
Revision history for this message
| Chris Johnston (cjohnston) | # |
review:
Approve
Unmerged revisions
- 685. By Adnane Belmadiaf
-
Fixed feed date parsing
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The modified parameter is not to be set by us. We are supposed to use whatever the server we're fetching-from has previously told us the feed was last modified. We should also have etag functionality included in this MR. See http://
Saving the correct last-modified time should be:
self.last_updated = data.modified_
and an etag would be accessed, and saved into a new field, from the response with:
self.last_etag = data.etag
we'd need to add the last_etag field into the model and update the migrations.