Merge lp://qastaging/~daker/ubuntu-ui-toolkit/fix.1665944 into lp://qastaging/ubuntu-ui-toolkit/staging
Proposed by
Adnane Belmadiaf
| Status: | Merged |
|---|---|
| Approved by: | Cris Dywan |
| Approved revision: | 2174 |
| Merged at revision: | 2178 |
| Proposed branch: | lp://qastaging/~daker/ubuntu-ui-toolkit/fix.1665944 |
| Merge into: | lp://qastaging/ubuntu-ui-toolkit/staging |
| Diff against target: |
13 lines (+2/-1) 1 file modified
src/imports/Components/ListItems/1.3/LabelVisual.qml (+2/-1) |
| To merge this branch: | bzr merge lp://qastaging/~daker/ubuntu-ui-toolkit/fix.1665944 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| ubuntu-sdk-build-bot | continuous-integration | Approve | |
| Cris Dywan | Approve | ||
|
Review via email:
|
|||
Commit message
Fix ListItem title/subtitle alignment & elide in RTL mode
Description of the change
Fix ListItem title/subtitle alignment & elide in RTL mode
To post a comment you must log in.
Revision history for this message
| ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote | # |
review:
Approve
(continuous-integration)
Revision history for this message
| ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote | # |
review:
Approve
(continuous-integration)
Revision history for this message
| ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote | # |
review:
Approve
(continuous-integration)
Revision history for this message
| ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote | # |
review:
Approve
(continuous-integration)
Revision history for this message
| ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote | # |
review:
Approve
(continuous-integration)
Revision history for this message
| ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote | # |
review:
Approve
(continuous-integration)
Revision history for this message
| ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote | # |
review:
Approve
(continuous-integration)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
I'm not entirely sure setting horizontalAlignment here is correct - but I'm prepared to accept it as-is and revisit it later if need be, I don't expect it to have other side effects.