webbrowser-app

Merge lp://qastaging/~daker/webbrowser-app/fix.1248728-2 into lp://qastaging/webbrowser-app

  1. fix.1248728-2
  2. Merge into trunk
Proposed by Adnane Belmadiaf
Status: Needs review
Proposed branch: lp://qastaging/~daker/webbrowser-app/fix.1248728-2
Merge into: lp://qastaging/webbrowser-app
Diff against target: 9 lines (+1/-0)
1 file modified
src/Ubuntu/Web/ua-overrides-mobile.js (+1/-0)
To merge this branch: bzr merge lp://qastaging/~daker/webbrowser-app/fix.1248728-2
Reviewer Review Type Date Requested Status
Ubuntu Phablet Team Pending
Review via email: mp+223171@code.qastaging.launchpad.net

Commit message

Fixed UA override for G+

To post a comment you must log in.
Revision history for this message
dobey (dobey) wrote :

This doesn't actually fix bug #1328183 here. It only changes the agent for plus.google.com but not other sites, so one will still see many ads for using an Android app, instead of just having the mobile sites work.

Reply
Revision history for this message
Adnane Belmadiaf (daker) wrote :

I doesn't fix the bug for sure, but i am trying to get the right UA for the webapps we ship so they will not show Android Ads.

Reply
Revision history for this message
dobey (dobey) wrote :

> I doesn't fix the bug for sure, but i am trying to get the right UA for the
> webapps we ship so they will not show Android Ads.

Shouldn't that be fixed in the webapps directly, rather than having a very large list of hard-coded URLs to modify the UA for in different ways, in the browser itself?

Reply
Revision history for this message
Olivier Tilloy (osomon) wrote :

> > I doesn't fix the bug for sure, but i am trying to get the right UA for the
> > webapps we ship so they will not show Android Ads.
>
> Shouldn't that be fixed in the webapps directly, rather than having a very
> large list of hard-coded URLs to modify the UA for in different ways, in the
> browser itself?

Yes, indeed. Unfortunately we don’t have a mechanism for webapps to specify a custom UA string yet.

Reply
Revision history for this message
Olivier Tilloy (osomon) wrote :

> > Shouldn't that be fixed in the webapps directly, rather than having a very
> > large list of hard-coded URLs to modify the UA for in different ways, in the
> > browser itself?
>
> Yes, indeed. Unfortunately we don’t have a mechanism for webapps to specify a
> custom UA string yet.

Filed bug #1370975 to track that issue.

Reply

Unmerged revisions

569. By Adnane Belmadiaf

Fixed UA override for G+

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: