webbrowser-app

Merge lp://qastaging/~daker/webbrowser-app/fix.1328183-twitter into lp://qastaging/webbrowser-app

fix.1328183-twitter
Merge into trunk

Proposed by Adnane Belmadiaf on 2014-06-15

Status:

Needs review

Proposed branch:

lp://qastaging/~daker/webbrowser-app/fix.1328183-twitter

Merge into:

lp://qastaging/webbrowser-app

Diff against target:

10 lines (+2/-0)

1 file modified

src/Ubuntu/Web/ua-overrides-mobile.js (+2/-0)

To merge this branch:

bzr merge lp://qastaging/~daker/webbrowser-app/fix.1328183-twitter

Undecided

Triaged

Link a bug report

Reviewer	Review Type	Date Requested	Status
Ubuntu Phablet Team		2014-06-15	Pending
Review via email: mp+223172@code.qastaging.launchpad.net

Commit message

Fixed UA override for twitter

Revision history for this message

David Barth (dbarth) wrote on 2014-07-24:

Does that change fix an issue?

Otherwise, since the override applies only when executed on mobile devices, I think it makes sense to send a different mobile UA on all of twitter. This way, if someone goes to twitter.com, he would still do so with the overriden UA.

What do you think?

Revision history for this message

Olivier Tilloy (osomon) wrote on 2014-07-24:

Note that if the only point of this override was to get rid of the prompt to install the android native application, then it shouldn’t be needed anymore, as this particular issue was addressed in http://bazaar.launchpad.net/~phablet-team/webbrowser-app/trunk/revision/610.

Revision history for this message

Mateo Salta (mateo-salta) wrote on 2016-08-06:

there is actually a new twitter web page for the phones, but you need to basically have the UA of a new Android feature phone, currently the official twitter webapp doesn't do this and presents the old interface