webbrowser-app

Merge lp://qastaging/~daker/webbrowser-app/fix.airbnb-smartbanner into lp://qastaging/webbrowser-app

  1. fix.airbnb-smartbanner
  2. Merge into trunk
Proposed by Adnane Belmadiaf
Status: Needs review
Proposed branch: lp://qastaging/~daker/webbrowser-app/fix.airbnb-smartbanner
Merge into: lp://qastaging/webbrowser-app
Diff against target: 54 lines (+39/-0)
2 files modified
src/Ubuntu/Web/UbuntuWebContext.qml (+6/-0)
src/Ubuntu/Web/airbnb-smartbanner.js (+33/-0)
To merge this branch: bzr merge lp://qastaging/~daker/webbrowser-app/fix.airbnb-smartbanner
Reviewer Review Type Date Requested Status
Olivier Tilloy Needs Fixing
Review via email: mp+230855@code.qastaging.launchpad.net

Commit message

Added a userscript to hide the airbnb smartbanner

To post a comment you must log in.
Revision history for this message
Olivier Tilloy (osomon) wrote :

The metadata of the user script should probably have a "@include" directive to limit the execution of the script to airbnb only.

Also, I’m not seeing this work (testing on desktop but forcing the formFactor to mobile, with your changes I’m still seeing the banner show up).

review: Needs Fixing
Reply
lp://qastaging/~daker/webbrowser-app/fix.airbnb-smartbanner updated
669. By Adnane Belmadiaf

Fixes

Revision history for this message
Olivier Tilloy (osomon) wrote :

Unfortunately it still doesn’t work for me. This is how I test it:

 - ensure the browser is closed, delete the cookie db: `rm ~/.local/share/webbrowser-app/cookies.sqlite*`
 - start the browser, enter "http://airbnb.com" in the address bar, validate

The banner advertising the android app shows up.

review: Needs Fixing
Reply

Unmerged revisions

669. By Adnane Belmadiaf

Fixes

668. By Adnane Belmadiaf

Added a userscript to hide the airbnb smartbanner

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: