Merge lp://qastaging/~dandrader/qtmir/fixIsPidFocused into lp://qastaging/qtmir
Proposed by
Daniel d'Andrada
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Gerry Boland | ||||
| Approved revision: | 551 | ||||
| Merged at revision: | 550 | ||||
| Proposed branch: | lp://qastaging/~dandrader/qtmir/fixIsPidFocused | ||||
| Merge into: | lp://qastaging/qtmir | ||||
| Diff against target: |
52 lines (+19/-12) 2 files modified
src/modules/Unity/Application/dbusfocusinfo.cpp (+18/-12) src/modules/Unity/Application/dbusfocusinfo.h (+1/-0) |
||||
| To merge this branch: | bzr merge lp://qastaging/~dandrader/qtmir/fixIsPidFocused | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Unity8 CI Bot (community) | continuous-integration | Approve | |
| Gerry Boland (community) | Approve | ||
|
Review via email:
|
|||
Commit message
DBusFocusInfo.
Description of the change
* Are there any related MPs required for this MP to build/function as expected? Please list.
No
* Did you perform an exploratory manual test run of your code change and any related functionality?
Yes
* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
Not applicable
To post a comment you must log in.
Revision history for this message
| Unity8 CI Bot (unity8-ci-bot) wrote | # |
review:
Approve
(continuous-integration)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
- Q_FOREACH (Application* application, m_applications) {
+ for (Application* application : m_applications) {
not a blocker, just a hint the original *might* be better. Ref:
http://
Other than that, code looks ok