Ubuntu UI Toolkit

Merge lp://qastaging/~dandrader/ubuntu-ui-toolkit/obey-env-var-grid-unit into lp://qastaging/ubuntu-ui-toolkit/staging

  1. obey-env-var-grid-unit
  2. Merge into staging
Proposed by Daniel d'Andrada
Status: Merged
Approved by: Cris Dywan
Approved revision: 2163
Merged at revision: 2163
Proposed branch: lp://qastaging/~dandrader/ubuntu-ui-toolkit/obey-env-var-grid-unit
Merge into: lp://qastaging/ubuntu-ui-toolkit/staging
Diff against target: 41 lines (+15/-10)
1 file modified
src/UbuntuToolkit/ucunits.cpp (+15/-10)
To merge this branch: bzr merge lp://qastaging/~dandrader/ubuntu-ui-toolkit/obey-env-var-grid-unit
Reviewer Review Type Date Requested Status
ubuntu-sdk-build-bot continuous-integration Approve
Cris Dywan Approve
Gerry Boland (community) Approve
Review via email: mp+315491@code.qastaging.launchpad.net

Commit message

If GRID_UNIT_PX set, always use it.

It should override scaling information from the QPA

To post a comment you must log in.
lp://qastaging/~dandrader/ubuntu-ui-toolkit/obey-env-var-grid-unit updated
2162. By Daniel d'Andrada

If GRID_UNIT_PX set, always use it.

It should override scaling information from the QPA

Revision history for this message
Gerry Boland (gerboland) wrote :

+1 from me, want to start removing explicit dependence on the env var

review: Approve
Revision history for this message
Cris Dywan (kalikiana) wrote :

So, as discussed briefly in IRC, if we agree to make GU always have precedence, we need the second constructor (with a Window) to also behave the same way.

review: Needs Fixing
lp://qastaging/~dandrader/ubuntu-ui-toolkit/obey-env-var-grid-unit updated
2163. By Daniel d'Andrada

Do likewise in the other UCUnits constructor

Revision history for this message
Daniel d'Andrada (dandrader) wrote :

On 26/01/2017 10:22, Christian Dywan wrote:
> Review: Needs Fixing
>
> So, as discussed briefly in IRC, if we agree to make GU always have precedence, we need the second constructor (with a Window) to also behave the same way.

Done.

Revision history for this message
Cris Dywan (kalikiana) wrote :

Looks good now. Thanks a lot!

review: Approve
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :

PASSED: Continuous integration, rev:2163
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/1419/
Executed test runs:
    None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7545/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/1419/rebuild

review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :

PASSED: Continuous integration, rev:2163
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/1384/
Executed test runs:
    None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7546/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/1384/rebuild

review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :

PASSED: Continuous integration, rev:2163
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-yakkety/198/
Executed test runs:
    None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7547/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-yakkety/198/rebuild

review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :

PASSED: Continuous integration, rev:2163
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1634/
Executed test runs:
    None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7548/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1634/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches