Merge lp://qastaging/~dandrader/unity-mir/fix_lp1234600 into lp://qastaging/unity-mir

Proposed by Daniel d'Andrada
Status: Merged
Approved by: Michał Sawicz
Approved revision: 103
Merged at revision: 111
Proposed branch: lp://qastaging/~dandrader/unity-mir/fix_lp1234600
Merge into: lp://qastaging/unity-mir
Diff against target: 277 lines (+177/-9)
5 files modified
src/modules/Unity/Application/Application.pro (+3/-1)
src/modules/Unity/Application/OSKController.qml (+8/-8)
src/modules/Unity/Application/plugin.cpp (+2/-0)
src/modules/Unity/Application/ubuntukeyboardinfo.cpp (+103/-0)
src/modules/Unity/Application/ubuntukeyboardinfo.h (+61/-0)
To merge this branch: bzr merge lp://qastaging/~dandrader/unity-mir/fix_lp1234600
Reviewer Review Type Date Requested Status
Michał Sawicz Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+190190@code.qastaging.launchpad.net

Commit message

Replace hardcoded keyboard size with info straight from ubuntu-keyboard

Have a communication channel between ubuntu-keyboard and unity-mir where
the former hands out all the information about itself that unity-mir might
be interested into.

Note that I'm just replacing a crude hack with a more sophisticated one.
That all should go away (including InputFilters) once a proper architecure gets
implemented.

Fixes LP#1234600

Description of the change

Not thoroughly tested.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Michał Sawicz (saviq) wrote :

Worky worky!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches