Merge lp://qastaging/~dandrader/unity8/cursorGridUnit into lp://qastaging/unity8
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Albert Astals Cid | ||||
| Approved revision: | 2544 | ||||
| Merged at revision: | 2568 | ||||
| Proposed branch: | lp://qastaging/~dandrader/unity8/cursorGridUnit | ||||
| Merge into: | lp://qastaging/unity8 | ||||
| Diff against target: |
401 lines (+88/-31) 7 files modified
plugins/Cursor/Cursor.qml (+5/-2) plugins/Cursor/CursorImageInfo.cpp (+21/-1) plugins/Cursor/CursorImageInfo.h (+10/-0) plugins/Cursor/CursorImageProvider.cpp (+33/-21) plugins/Cursor/CursorImageProvider.h (+9/-6) qml/Shell.qml (+2/-0) tests/plugins/Cursor/tst_Cursor.qml (+8/-1) |
||||
| To merge this branch: | bzr merge lp://qastaging/~dandrader/unity8/cursorGridUnit | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Unity8 CI Bot | continuous-integration | Approve | |
| Albert Astals Cid (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Cursor: make its size grid unit based
So that it scales along with the rest of the UI
Description of the change
* Are there any related MPs required for this MP to build/function as expected? Please list.
No
* Did you perform an exploratory manual test run of your code change and any related functionality?
Yes.
To test apply this patch http://
Then use Alt+A and Alt+S to decrease and increase the requested cursor size respectively. You should see 3 different cursor sizes, as DMZ theme (the default ubuntu one) provides only 3 different resolutions of its cursor images.
Applying scaling on top of the bitmap based cursor to get a exact match of the requested size would cause blurriness and other artifacts.
* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A
* If you changed the UI, has there been a design review?
N/A
| Unity8 CI Bot (unity8-ci-bot) wrote | # |
| Unity8 CI Bot (unity8-ci-bot) wrote | # |
| Unity8 CI Bot (unity8-ci-bot) wrote | # |
FAILED: Continuous integration, rev:2543
https:/
Executed test runs:
FAILURE: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
Click here to trigger a rebuild:
https:/