Merge lp://qastaging/~dandrader/unity8/hiddenWindows into lp://qastaging/unity8

Proposed by Daniel d'Andrada
Status: Superseded
Proposed branch: lp://qastaging/~dandrader/unity8/hiddenWindows
Merge into: lp://qastaging/unity8
Diff against target: 1921 lines (+936/-81)
42 files modified
CMakeLists.txt (+2/-2)
debian/control (+5/-5)
plugins/Greeter/Unity/Launcher/quicklistmodel.cpp (+2/-0)
plugins/Unity/Launcher/CMakeLists.txt (+2/-0)
plugins/Unity/Launcher/launcheritem.cpp (+30/-6)
plugins/Unity/Launcher/launcheritem.h (+3/-2)
plugins/Unity/Launcher/launchermodel.cpp (+47/-14)
plugins/Unity/Launcher/launchermodel.h (+3/-1)
plugins/Unity/Launcher/quicklistentry.cpp (+11/-0)
plugins/Unity/Launcher/quicklistentry.h (+4/-0)
plugins/Unity/Launcher/quicklistmodel.cpp (+9/-0)
plugins/Unity/Launcher/quicklistmodel.h (+1/-0)
plugins/Utils/CMakeLists.txt (+1/-0)
plugins/Utils/plugin.cpp (+2/-0)
plugins/Utils/quicklistproxymodel.cpp (+72/-0)
plugins/Utils/quicklistproxymodel.h (+52/-0)
plugins/WindowManager/CMakeLists.txt (+2/-0)
plugins/WindowManager/TopLevelWindowModel.cpp (+64/-20)
plugins/WindowManager/TopLevelWindowModel.h (+6/-2)
plugins/WindowManager/Window.cpp (+32/-1)
plugins/WindowManager/Window.h (+18/-2)
plugins/WindowManager/WindowManagerGlobal.h (+23/-0)
qml/Launcher/Launcher.qml (+1/-0)
qml/Launcher/LauncherPanel.qml (+8/-1)
qml/Shell.qml (+1/-0)
qml/Stage/Stage.qml (+8/-0)
tests/mocks/Unity/Application/MirSurface.cpp (+4/-0)
tests/mocks/Unity/Application/MirSurface.h (+4/-0)
tests/mocks/Unity/Application/MirSurfaceListModel.cpp (+7/-7)
tests/mocks/Unity/Application/MirSurfaceListModel.h (+7/-9)
tests/mocks/Unity/Launcher/MockLauncherModel.h (+1/-1)
tests/mocks/Unity/Launcher/MockQuickListModel.cpp (+3/-1)
tests/mocks/Unity/Launcher/MockQuickListModel.h (+2/-0)
tests/mocks/Utils/CMakeLists.txt (+2/-0)
tests/mocks/Utils/plugin.cpp (+2/-0)
tests/plugins/CMakeLists.txt (+1/-0)
tests/plugins/Unity/Launcher/CMakeLists.txt (+3/-0)
tests/plugins/Unity/Launcher/launchermodeltest.cpp (+85/-7)
tests/plugins/WindowManager/CMakeLists.txt (+34/-0)
tests/plugins/WindowManager/UnityApplicationMocks.h (+200/-0)
tests/plugins/WindowManager/tst_TopLevelWindowModel.cpp (+130/-0)
tests/qmltests/Launcher/tst_Launcher.qml (+42/-0)
To merge this branch: bzr merge lp://qastaging/~dandrader/unity8/hiddenWindows
Reviewer Review Type Date Requested Status
Unity8 CI Bot continuous-integration Needs Fixing
Albert Astals Cid (community) Approve
Review via email: mp+319917@code.qastaging.launchpad.net

This proposal has been superseded by a proposal from 2017-03-16.

Commit message

TopLevelWindowModel: don't put hidden windows in the model

From the UI point of view, it's as if they didn't exist.

Description of the change

See bug description for steps on how to manually test this.

* Are there any related MPs required for this MP to build/function as expected? Please list.
No.

* Did you perform an exploratory manual test run of your code change and any related functionality?
Yes.

* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
Not applicable.

* If you changed the UI, has there been a design review?
Not applicable.

To post a comment you must log in.
Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote :

FAILED: Continuous integration, rev:2868
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/3390/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/4469
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=qmluitests.sh/2683
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=zesty,testname=qmluitests.sh/2683
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/4497
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4324
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4324/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4324
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4324/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4324
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4324/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4324
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4324/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4324
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4324/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4324
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4324/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/3390/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote :

PASSED: Continuous integration, rev:2869
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/3393/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/4472
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=qmluitests.sh/2685
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=zesty,testname=qmluitests.sh/2685
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/4500
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4327
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4327/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4327
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4327/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4327
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4327/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4327
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4327/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4327
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4327/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4327
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4327/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/3393/rebuild

review: Approve (continuous-integration)
Revision history for this message
Albert Astals Cid (aacid) wrote :

 * Did you perform an exploratory manual test run of the code change and any related functionality?
Yes

 * Did CI run pass? If not, please explain why.
Yes

review: Approve
2869. By Daniel d'Andrada

merge ../allowClientResize

2870. By Daniel d'Andrada

TopLevelWindowModel: don't put hidden windows in the model

From the UI point of view, it's as if they didn't exist.

Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote :
review: Needs Fixing (continuous-integration)

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches