Boots

Merge lp://qastaging/~daniel-nichter/boots/vertical-output into lp://qastaging/boots

vertical-output
Merge into trunk

Proposed by Daniel Nichter on 2010-05-16

Status:	Needs review
Proposed branch:	lp://qastaging/~daniel-nichter/boots/vertical-output
Merge into:	lp://qastaging/boots
Diff against target:	291 lines (+152/-60) 3 files modified boots/app/client_config.py (+6/-0) boots/lib/ui/plain.py (+70/-56) tests/boots/lib/ui/ui_tests.py (+76/-4)
To merge this branch:	bzr merge lp://qastaging/~daniel-nichter/boots/vertical-output
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Jay Pipes		2010-05-16	Approve on 2010-05-17
Review via email: mp+25407@code.qastaging.launchpad.net

Description of the change

Adds --vertical-output option to enable mysql cli \G-like output:

> show master status;
=================================== Row 1 ====================================
            File: mysql-bin.000001
        Position: 364
    Binlog_Do_DB:
Binlog_Ignore_DB:

1 row in set (0.00s server | +0.00s working)

Revision history for this message

Jay Pipes (jaypipes) wrote on 2010-05-17:

Awesomeness! Daniel, is it possible to include a simple test case for this new functionality?

Unit testing is pretty light right now. However, from a glance, it looks like adding a test method to the TestPlain class in /tests/lib/ui/ui_tests.py is the right way to go...

Cheers!

jay

review: Approve

Revision history for this message

Daniel Nichter (daniel-nichter) wrote on 2010-05-18:

> Awesomeness! Daniel, is it possible to include a simple test case for this
> new functionality?

Yes, I will write tests...

lp://qastaging/~daniel-nichter/boots/vertical-output updated on 2010-06-02

165. By Daniel Nichter on 2010-06-02: Move padded(), show_NULL() and _gen_output() out of present() for testing; prepend _ to first two. Add ui tests.

Revision history for this message

Daniel Nichter (daniel-nichter) wrote on 2010-06-02:

Added some basic ui tests. My understanding of boots internals is not complete so if the _gen_output() tests in particular seem odd please correct/enlighten me. Thanks.

Unmerged revisions

165. By Daniel Nichter on 2010-06-02: Move padded(), show_NULL() and _gen_output() out of present() for testing; prepend _ to first two. Add ui tests.
164. By Daniel Nichter on 2010-05-16: Add --vertical-output.